Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working ga.ajax.js #113

Open
JanMikes opened this issue Jan 21, 2015 · 2 comments
Open

Not working ga.ajax.js #113

JanMikes opened this issue Jan 21, 2015 · 2 comments

Comments

@JanMikes
Copy link

Since url is contained in settings.url (payload.url is always undefined), the extensions was useless - it never pushed pageview tracking to GA.

This fix works fine for me, I have changed lines 4 and 5 like this:

success: function (payload, status, jqXHR, settings) {
        var url = settings.url || payload.redirect;

Sorry for not sending pull request, but I have never tried it yet,.. maybe in future :)

@Majkl578
Copy link

IIRC you were supposed to send actual URL of the ajax-loaded page, in payload.url.

@fprochazka
Copy link
Contributor

IMHO the redirect should not be tracked, because it will be tracked after the actual redirect.

@lexinek please do try to send pullrequest - fork the repository, create new branch, commit changes and open pullrequest using github GUI. There is nothing to worry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants