Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not select image after upgraded to version 5.5 #146

Open
formulando opened this issue Aug 11, 2020 · 9 comments
Open

does not select image after upgraded to version 5.5 #146

formulando opened this issue Aug 11, 2020 · 9 comments

Comments

@formulando
Copy link

after upgraded to version 5.5 and plugin crashed when trying to choose images.

displays the error:

Uncaught ReferenceError: setPostThumbnailL10n is not defined
at Object.setAsThumbnail (multi-post-thumbnails-admin.js?ver=c440fd0f5941d17b9a3e5658f4015e5b:31)
at Object.cb (post-new.php?post_type=acompanhante:658)
at h.Collection. (media-modal.js?ver=c440fd0f5941d17b9a3e5658f4015e5b:39)
at p (backbone.min.js?ver=1.4.0:2)
at f (backbone.min.js?ver=1.4.0:2)
at l (backbone.min.js?ver=1.4.0:2)
at h.Collection.n.trigger (backbone.min.js?ver=1.4.0:2)
at h.Collection._onModelEvent (backbone.min.js?ver=1.4.0:2)
at p (backbone.min.js?ver=1.4.0:2)
at f (backbone.min.js?ver=1.4.0:2)

already tried the alternatives https://wordpress.org/support/topic/bugfix-bug-with-multiple-post-types-wp-4-5/

but I was not successful, I will downgrade the wp to see if it returns to normal.

did anyone experience the same problem?

@formulando
Copy link
Author

If you have the same problem and have not found a solution. You can use the "WP Downgrade | Specific Core Version" plugin to revert to version 5.4.2 of the WP that works well

@szczys
Copy link

szczys commented Aug 12, 2020

We have experienced the same behavior and downgraded to 5.4.2 until a solution can be found.

@szczys
Copy link

szczys commented Aug 13, 2020

Looking at the wordpress code it seems that setPostThumbnailL10n has changed to wp.i18n. Here's the commit:

WordPress/WordPress@4377e9a#diff-4bfa11da57ff2600004bb500368247f4

Looks like this is internationalization strings? https://codex.wordpress.org/I18n_for_WordPress_Developers

@szczys
Copy link

szczys commented Aug 14, 2020

I have tested the changes in PR #148 with version 5.4.2 and it is working so no issue with users who have not yet made the 5.5 update.

@aliciaduffy
Copy link

This fixed the plugin for us in WordPress 5.5

@ceprdata
Copy link

I tested it and it didn't fix the plugin in 5.5. Hoping the plugin creator will test and correct the issue soon.

@szczys
Copy link

szczys commented Aug 20, 2020

@ceprdata Some people are reporting that they needed to clear browser cache before the fix took effect.

@undermeadow
Copy link

@ceprdata We had to clear our Cloudflare cache, Varnish, and browser cache before it worked but it did finally work for us.

kasparsd added a commit to interactive-one/multi-post-thumbnails that referenced this issue Aug 27, 2020
@wenkunst
Copy link

Works with WP 5.5! Great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants