Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang image path customization in dockerfile to use Docker Proxy #99

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Golang image path customization in dockerfile to use Docker Proxy #99

wants to merge 3 commits into from

Conversation

ridaz-zz
Copy link
Contributor

@ridaz-zz ridaz-zz commented Nov 17, 2021 •
edited
Loading

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
Due to dockerhub pull limit, internal registry can be used to fetch the golang image and deploy VDO.
This PR will bring in support to use docker proxy.

Which issue(s) this PR fixes:

Fixes #98

Test Report Added?:
/kind TESTED

Test Report:
Able to deploy VDO using docker proxy.

make deploy DOCKER_PROXY=harbor-repo.vmware.com/dockerhub-proxy-cache/library/

[builder 1/7] FROM harbor-repo.vmware.com/dockerhub-proxy-cache/library/golang:1.16@sha256:1e5f22f0c2efda5354823d26a9dde6802b753ec97156ee894d626721d33da3b8  

kubectl get pods -A

NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
kube-system          vsphere-cloud-controller-manager-8cd7k       1/1     Running   0          2m40s
kube-system          vsphere-csi-controller-55f949b89-b5spz       6/6     Running   0          2m28s
kube-system          vsphere-csi-node-27fwg                       3/3     Running   0          2m27s
vmware-system-vdo    vdo-controller-manager-6859d5c64c-h9dfh      2/2     Running   0          2m52s


kubectl get vdoconfig -A -o yaml
apiVersion: v1
items:
- apiVersion: vdo.vmware.com/v1alpha1
  kind: VDOConfig
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"vdo.vmware.com/v1alpha1","kind":"VDOConfig","metadata":{"annotations":{},"name":"vdoconfig-sample","namespace":"vmware-system-vdo"},"spec":{"cloudProvider":{"vsphereCloudConfigs":["vspherecloudconfig-sample"]},"storageProvider":{"vsphereCloudConfig":"vspherecloudconfig-sample"}}}
    creationTimestamp: "2021-11-17T09:49:36Z"
    generation: 1
    name: vdoconfig-sample
    namespace: vmware-system-vdo
    resourceVersion: "4132"
    uid: 621714f1-c162-4206-95ac-0b6eedfa193b
  spec:
    cloudProvider:
      vsphereCloudConfigs:
      - vspherecloudconfig-sample
    storageProvider:
      vsphereCloudConfig: vspherecloudconfig-sample
  status:
    cpi:
      'nodeStatus ':
        kind-control-plane: ready
      phase: Configured
    csi:
      phase: Deployed
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

@ridaz-zz ridaz-zz added the enhancement New feature or request label Nov 17, 2021
@ridaz-zz ridaz-zz self-assigned this Nov 17, 2021
@ridaz-zz ridaz-zz changed the title Golang image path customization in dockerfile to use Docker Proxy [WIP]Golang image path customization in dockerfile to use Docker Proxy Nov 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #99 (e17e042) into main (490a975) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   50.17%   50.17%           
=======================================
  Files           6        6           
  Lines        1401     1401           
=======================================
  Hits          703      703           
  Misses        600      600           
  Partials       98       98
Flag Coverage Δ
unittests 50.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490a975...e17e042. Read the comment docs.

@ridaz-zz ridaz-zz changed the title [WIP]Golang image path customization in dockerfile to use Docker Proxy Golang image path customization in dockerfile to use Docker Proxy Nov 17, 2021
asifdxtreme
asifdxtreme approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aggarwalta
aggarwalta approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@aggarwalta aggarwalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asifdxtreme asifdxtreme added this to the Sprint-5 milestone Nov 18, 2021
@asifdxtreme asifdxtreme modified the milestones: Sprint-5, Sprint-6 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aggarwalta aggarwalta aggarwalta approved these changes

@lgayatri lgayatri lgayatri approved these changes

@DimpleRajaVamsi DimpleRajaVamsi DimpleRajaVamsi approved these changes

@asifdxtreme asifdxtreme asifdxtreme approved these changes

@jvrahav jvrahav Awaiting requested review from jvrahav

Assignees

@ridaz-zz ridaz-zz

Labels
cla-not-required enhancement New feature or request
Projects
None yet
Milestone
Sprint-6
Development

Successfully merging this pull request may close these issues.

Customize golang image path in dockerfile to allow using internal registry
8 participants
@ridaz-zz @codecov-commenter @asifdxtreme @DimpleRajaVamsi @lgayatri @aggarwalta @vmwclabot @ridaz