Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subject to Cloud Event #117

Closed
embano1 opened this issue Oct 22, 2020 · 9 comments
Closed

Add subject to Cloud Event #117

embano1 opened this issue Oct 22, 2020 · 9 comments
Labels
wontfix This will not be worked on

Comments

@embano1
Copy link
Contributor

embano1 commented Oct 22, 2020

As mentioned in the comment the cloud events subject is currently not set for vSphere events.

// TODO(mattmoor): Consider setting the subject

Since vSphere events can be arbitrary (Alerts, VM related events, 3rd party, etc.), i.e. there is not a standard/stable definition of subject, the question is whether subject can (should) be set on a vCenter cloud event. There are definitely valid use cases, e.g. setting the VM moRef for a VmPoweredOnEvent or host moRef for a EnteredMaintenanceModeEvent.

Since moRef is composed of a type and value, a composite key for subject might be useful, e.g. VirtualMachine/vm-56.

@vaikas
Copy link
Contributor

vaikas commented Oct 22, 2020

Yea, so looking at the ManagedObjectReference, type/value seems reasonable. Though, I wonder if we're processing events from multiple vspheres if we need to prefix it with something else also to avoid collisions?

@embano1
Copy link
Contributor Author

embano1 commented Oct 22, 2020

Wouldn't source tie the moRef to the concrete vcenter instance, i.e. composite of source and subject is unique?

@vaikas
Copy link
Contributor

vaikas commented Oct 22, 2020

Probably, just wanted to jot it down while I was thinking about it :)

@vaikas
Copy link
Contributor

vaikas commented Oct 23, 2020

/assign

@vaikas vaikas self-assigned this Oct 23, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@vaikas vaikas removed their assignment Feb 11, 2021
@embano1
Copy link
Contributor Author

embano1 commented Mar 3, 2021

/remove-lifecycle stale

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@embano1
Copy link
Contributor Author

embano1 commented Jun 2, 2021

@embano1 embano1 added the wontfix This will not be worked on label Jun 30, 2021
@embano1
Copy link
Contributor Author

embano1 commented Jun 30, 2021

Closing with wontfix since there's currently no easy way to extract a well-defined "subject" from an arbitrary vSphere event.

@embano1 embano1 closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants