-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subject to Cloud Event #117
Comments
Yea, so looking at the ManagedObjectReference, type/value seems reasonable. Though, I wonder if we're processing events from multiple vspheres if we need to prefix it with something else also to avoid collisions? |
Wouldn't |
Probably, just wanted to jot it down while I was thinking about it :) |
/assign |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
Closing with |
As mentioned in the comment the cloud events
subject
is currently not set for vSphere events.sources-for-knative/pkg/vsphere/adapter.go
Line 101 in 6826a54
Since vSphere events can be arbitrary (Alerts, VM related events, 3rd party, etc.), i.e. there is not a standard/stable definition of
subject
, the question is whethersubject
can (should) be set on a vCenter cloud event. There are definitely valid use cases, e.g. setting the VMmoRef
for aVmPoweredOnEvent
or hostmoRef
for aEnteredMaintenanceModeEvent
.Since
moRef
is composed of atype
andvalue
, a composite key forsubject
might be useful, e.g.VirtualMachine/vm-56
.The text was updated successfully, but these errors were encountered: