Resource pluralization for Postgres #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashed Kamal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 93.36% 93.02% -0.35%
==========================================
Files 16 16
Lines 769 774 +5
==========================================
+ Hits 718 720 +2
- Misses 40 42 +2
- Partials 11 12 +1
Continue to review full report at Codecov.
|
scothis
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rashed Kamal [email protected]
Pull request
What this PR does / why we need it
Tactical fix for
Postgresresource pluralization. Correcting this bug using DynamicRestMapper requires major refactoring. We will clean up this implementation as we refactor this operator.Which issue(s) this PR fixes
Fixes #190
Describe testing done for PR
Unit test for
pkg/resolver/serviceable_resolver_test.gorequires registering types. API groupsql.tanzu.vmware.comis not public and did not register. Manual testing installing Tanzu Postgres OperatorAdditional information or special notes for your reviewer