Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tag release bundles with the released version #162

Open
voor opened this issue Aug 11, 2021 · 1 comment
Open

Please tag release bundles with the released version #162

voor opened this issue Aug 11, 2021 · 1 comment

Comments

@voor
Copy link
Member

voor commented Aug 11, 2021

Hi, I downloaded the latest release (0.4.0):

$ imgpkg copy --tar service-bindings-bundle-0.4.0.tar --to-repo repo.example.com/imgpkg/bundles/service-bindings --lock-output current-version.yaml
copy | importing 2 images...

 32.52 MiB / 32.52 MiB [==================================================================================================================================================] 100.00% 59.24 MiB/s 0s

copy | done uploading images
Succeeded
$ cat current-version.yaml 
---
apiVersion: imgpkg.carvel.dev/v1alpha1
bundle:
  image: repo.example.com/imgpkg/bundles/service-bindings@sha256:9d79a03eeacfd01269f368f778ef9fcfab6f413cbf1293a43f39dc925bfc790a
  tag: latest
kind: BundleLock

I would love if this was tagged to 0.4.0 instead of latest

I think these two lines:
https://github.com/vmware-labs/service-bindings/blob/main/.github/workflows/ci.yaml#L88-L89

Just needs to change to include the current version in the tag, if that's at all possible.
So instead of:

imgpkg push -f "bundle" -b "${BUNDLE}"
imgpkg copy -b "${BUNDLE}" --to-tar bundle/service-bindings-bundle.tar

Have:

imgpkg push -f "bundle" -b "${BUNDLE}:${VERSION}"
imgpkg copy -b "${BUNDLE}:${VERSION}" --to-tar bundle/service-bindings-bundle.tar
@scothis
Copy link
Contributor

scothis commented Aug 16, 2021

@voor I'd love to, but unfortunately it's blocked by a limitation in imgpkg. As a stop gap, I'd recommend including the version number in the repo name instead of as a tag. Something like ${BUNDLE}/v${VERSION} assuming nested repos are supported by your registry.

Blocked by carvel-dev/imgpkg#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants