Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage conventions to return a diff of the changes rather than a full PodTemplateSpec #60

Open
scothis opened this issue Mar 24, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@scothis
Copy link
Contributor

scothis commented Mar 24, 2022

Over time, Kubernetes continues to add new fields within the PodTemplateSpec. If a convention is compiled against an older version of the Kubernetes API types, then it is possible that a field will be dropped as it comes back from the convention. For example, K8s 1.23 added support for GRPC based probe handlers. If a PodIntent used that new feature and a convention was compiled against K8s 1.22, then the intended probe handler would be lost in the round trip.

The PodConventionContextStatus current has a PodTemplateSpec that is the template as returned from the convention. Instead, we should encourage conventions to return a diff representing the change to the PodTemplateSpec.

While the full PodTemplateSpec response should be deprecated, for backwards compatibility the convention controller must continue to allow conventions to return a full PodTemplateSpec or a diff.

@scothis scothis added enhancement New feature or request bug Something isn't working labels Mar 24, 2022
@seagomezar seagomezar added this to the 0.4.2 milestone Apr 3, 2023
@rashedkvm rashedkvm removed this from the 0.4.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants