Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replaces from go.mod #58

Closed
migmartri opened this issue Aug 24, 2021 · 3 comments · Fixed by #68
Closed

Remove replaces from go.mod #58

migmartri opened this issue Aug 24, 2021 · 3 comments · Fixed by #68

Comments

@migmartri
Copy link
Contributor

We have some module replaces in our main go.mod, we need to figure out a way to move away from them and rely on referencing upstream libraries. The most difficult one will be to move to upstream yaml.v3

$ go install github.com/vmware-tanzu/[email protected]
go install github.com/vmware-tanzu/[email protected]: github.com/vmware-tanzu/[email protected]
        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.
@migmartri migmartri changed the title Remove replaces Remove replaces from go.mod Aug 24, 2021
@josvazg
Copy link
Contributor

josvazg commented Aug 25, 2021

That one in particular depends on us not using directly github.com/atomatt/yaml right?
Didn't we have an issue for that already?

@petewall
Copy link
Contributor

This was closed because of PR #68 , but that only solves 2 out of the 3 replace rules. Reopening...

@petewall
Copy link
Contributor

petewall commented Dec 2, 2022

Closing as the remaining of this issue will be solved by #91

@petewall petewall closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants