Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Do not show same image relocation twice #52

Open
migmartri opened this issue Aug 24, 2021 · 2 comments
Open

UX: Do not show same image relocation twice #52

migmartri opened this issue Aug 24, 2021 · 2 comments

Comments

@migmartri
Copy link
Contributor

For example, the following command shows the same relocation twice, it should be enough to show it once.

 harbor-repo.vmware.com/tanzu_isv_engineering/tiny:tiniest => projects.registry.vmware.com/relocated/example2/tiny:tiniest (sha256:adf10351862ad5351ac2e714e04a0afb020b9df658ac99a07cbf49c0e18f8e43) 
$ relok8s chart move --image-patterns ./test/fixtures/testchart.images.yaml --registry projects.registry.vmware.com --repo-prefix relocated/example2 ./test/fixtures/testchart/
Computing relocation...

Image copies:
 harbor-repo.vmware.com/tanzu_isv_engineering/tiny:tiniest => projects.registry.vmware.com/relocated/example2/tiny:tiniest (sha256:adf10351862ad5351ac2e714e04a0afb020b9df658ac99a07cbf49c0e18f8e43) (push required)
 harbor-repo.vmware.com/tanzu_isv_engineering/tiny:tiniest => projects.registry.vmware.com/relocated/example2/tiny@sha256:adf10351862ad5351ac2e714e04a0afb020b9df658ac99a07cbf49c0e18f8e43 (sha256:adf10351862ad5351ac2e714e04a0afb020b9df658ac99a07cbf49c0e18f8e43) (push required)
 harbor-repo.vmware.com/dockerhub-proxy-cache/library/busybox:1.33.1 => projects.registry.vmware.com/relocated/example2/busybox@sha256:b862520da7361ea093806d292ce355188ae83f21e8e3b2a3ce4dbdba0a230f83 (sha256:b862520da7361ea093806d292ce355188ae83f21e8e3b2a3ce4dbdba0a230f83) (push required)
 harbor-repo.vmware.com/tanzu_isv_engineering/tiny:tiniest => projects.registry.vmware.com/relocated/example2/tiny:tiniest (sha256:adf10351862ad5351ac2e714e04a0afb020b9df658ac99a07cbf49c0e18f8e43) (already exists)

@josvazg
Copy link
Contributor

josvazg commented Aug 25, 2021

What should be the criteria to pick the shown?

  • Should the first of the list?
  • Show the rolling one? or the one with the @sha?

Also skipping those might be misleading, as those move are different tags tiny:tiniest vs iny@sha256:ad... they are in a way different updates, even if one is just an alias.
Omitting might create confusion to consumers not knowing of the the tags was applied?

@petewall
Copy link
Contributor

petewall commented Nov 9, 2021

Related to #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@migmartri @josvazg @petewall and others