fix: Update subpath from DeepCopy instead of pointer #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Alfonso <[email protected]>
anibmurthy
previously approved these changes
May 24, 2023
Signed-off-by: Diego Alfonso <[email protected]>
odinnordico
force-pushed
the
fix-subpath-lsp
branch
from
cfcd580
to
fd3b47a
Compare
warango4
reviewed
May 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #580 +/- ##
==========================================
+ Coverage 85.76% 85.78% +0.02%
==========================================
Files 68 68
Lines 4249 4255 +6
==========================================
+ Hits 3644 3650 +6
Misses 473 473
Partials 132 132
|
Signed-off-by: Diego Alfonso <[email protected]>
Signed-off-by: Diego Alfonso <[email protected]>
odinnordico
force-pushed
the
fix-subpath-lsp
branch
from
20fdf7b
to
081a2d7
Compare
warango4
reviewed
May 25, 2023
odinnordico
force-pushed
the
fix-subpath-lsp
branch
from
d67ffa9
to
7f53ada
Compare
Signed-off-by: Diego Alfonso <[email protected]>
odinnordico
force-pushed
the
fix-subpath-lsp
branch
from
7f53ada
to
d66f14f
Compare
warango4
reviewed
May 29, 2023
warango4
reviewed
May 29, 2023
Signed-off-by: Diego Alfonso <[email protected]>
Signed-off-by: Diego Alfonso <[email protected]>
odinnordico
force-pushed
the
fix-subpath-lsp
branch
from
181248e
to
6668c91
Compare
warango4
approved these changes
May 29, 2023
anibmurthy
approved these changes
May 30, 2023
warango4
added a commit
to warango4/apps-cli-plugin
that referenced
this pull request
Jun 13, 2023
…ware-tanzu#580)" This reverts commit 3cedc29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
When doing the
MergeoverWorkloadSpec, on each "sub-Merge",ResetSource(which convertsSource = nil) was used but keeping a stash with the previous value of the section (likeSource) but as those are pointer references then whenResetSourceis called it changes the whole reference, then the validations in others struct members fail.This PR uses
DeepCopyto keep the "stash" so the further validations/checks are against the actual values.Which issue(s) this PR fixes
Fixes #565
Describe testing done for PR
Additional information or special notes for your reviewer