Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Examples for Tanzu Sources for Knative #1073

Closed
lamw opened this issue Jun 24, 2023 · 0 comments · Fixed by #1080
Closed

Update Examples for Tanzu Sources for Knative #1073

lamw opened this issue Jun 24, 2023 · 0 comments · Fixed by #1080
Assignees
@lamw
Labels
enhancement New feature or request
Milestone
v0.8.0

Comments

@lamw
Copy link
Contributor

lamw commented Jun 24, 2023

Is your feature request related to a problem? Please describe.
Due to the schema changes between event-router and Tanzu Sources for Knative, the examples will need to be updated to reflect this change.

To preserve the existing examples, I'm thinking of renaming the folder to event-router-examples, this way its clear and existing structure can be preserved for browsing and historical purposes
@lamw lamw added the enhancement New feature or request label Jun 24, 2023
@lamw lamw added this to the v0.8.0 milestone Jun 24, 2023
@lamw lamw self-assigned this Jun 24, 2023
lamw pushed a commit to lamw/vcenter-event-broker-appliance that referenced this issue Jul 18, 2023
feat: Update examples for Tanzu Sources for Knative
c077900 
Closes: vmware-samples#1073
Signed-off-by: William Lam <[email protected]>
@lamw lamw mentioned this issue Jul 18, 2023
Merged
15 tasks
lamw pushed a commit to lamw/vcenter-event-broker-appliance that referenced this issue Jul 26, 2023
feat: Update examples for Tanzu Sources for Knative
407630e 
Closes: vmware-samples#1073
Signed-off-by: William Lam <[email protected]>
lamw pushed a commit to lamw/vcenter-event-broker-appliance that referenced this issue Aug 4, 2023
feat: Update examples for Tanzu Sources for Knative
1cd0e39 
Closes: vmware-samples#1073
Signed-off-by: William Lam <[email protected]>
lamw pushed a commit to lamw/vcenter-event-broker-appliance that referenced this issue Aug 4, 2023
feat: Update examples for Tanzu Sources for Knative
504b6cf 
Closes: vmware-samples#1073
Signed-off-by: William Lam <[email protected]>
@lamw lamw closed this as completed in #1080 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamw lamw

Labels
enhancement New feature or request
Projects
VEBA Project
Status: Done
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Update examples for Tanzu Sources for Knative lamw/vcenter-event-broker-appliance
1 participant
@lamw