Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rustls to avoid compiling OpenSSL #137

Open
Angelmmiguel opened this issue May 25, 2023 · 4 comments
Open

Switch to rustls to avoid compiling OpenSSL #137

Angelmmiguel opened this issue May 25, 2023 · 4 comments
Assignees
Labels
🚀 enhancement New feature or request

Comments

@Angelmmiguel
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the project relies on OpenSSL to perform https requests to pull the different runtimes. We are using the reqwest crate for it. When compiling the project to Linux with the musl toolchain, we started facing errors due to missing dependencies.

To fix it, we configured the openssl dependency to build the project using the vendored feature. We only applied this to the musl targets:

[target.x86_64-unknown-linux-musl.dependencies]
openssl = { version = "=0.10.48", features = ["vendored"] }
[target.aarch64-unknown-linux-musl.dependencies]
openssl = { version = "=0.10.48", features = ["vendored"] }

We want to avoid compiling this dependency as it causes other issues in the past.

Describe the solution you'd like

The goal is to use the rustls crate. We can configure reqwest to use it via features. However, we cannot do it yet due to an issue with the Windows aarch64 target in the ring dependency. The problem is fix, although the new release is not public yet.

You can track the current status on: briansmith/ring#1551

Describe alternatives you've considered

No response

Additional context

No response

@Angelmmiguel
Copy link
Contributor Author

The ring 0.17.0 release is already out! I will open a PR to close this.

@Angelmmiguel Angelmmiguel self-assigned this Oct 4, 2023
@Angelmmiguel Angelmmiguel modified the milestones: v1.6.0, v1.6.2 Oct 4, 2023
@Angelmmiguel
Copy link
Contributor Author

I'm now waiting for rustls to update ring to the latest version.

@Angelmmiguel Angelmmiguel removed this from the v1.6.2 milestone Oct 4, 2023
@Angelmmiguel
Copy link
Contributor Author

The changes in rustls are merged. Now, we are waiting for the backport to the 0.21.X version. Then, we will be able to switch as 0.22 will take more time.

@Angelmmiguel
Copy link
Contributor Author

Blocked now by #256

@Angelmmiguel Angelmmiguel removed this from the v1.8.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant