Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Commit 62558c0

Browse files
authored
[CONTRIBUTING.md] Rename section
Renamed "Closing a pull request" to "Merging a pull request".
1 parent f8bf049 commit 62558c0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ git push --force-with-lease origin my-new-feature
6161
Be sure to add a comment to the PR indicating your new changes are ready to review, as GitHub does not generate a
6262
notification when you git push.
6363

64-
### Closing a pull request
64+
### Merging a pull request
6565

66-
Since we run benchmarks as part of CI it's good practice to preserve the commit IDs of the feature branch
66+
Since we run benchmarks as part of CI it's good practice to preserve the commit IDs of the feature branch
6767
we've worked on (and benchmarked). Unfortunately, [the github UI does not have support for this](https://github.com/community/community/discussions/4618)
6868
(it only allows rebase, squash and merge commits to close PRs).
69-
Therefore, it's recommended to close and merge PRs using the following git CLI invocation:
69+
Therefore, it's recommended to merge PRs using the following git CLI invocation:
7070

7171
```shell
7272
git checkout main

0 commit comments

Comments
 (0)