Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering of itab.h and itab.c varies between runs and Python versions #144

Open
martindorey opened this issue May 10, 2023 · 0 comments
Open

Ordering of itab.h and itab.c varies between runs and Python versions #144

martindorey opened this issue May 10, 2023 · 0 comments

Comments

@martindorey
Copy link

This makes it difficult to tell whether changes to scripts/ud_opcode.py or scripts/ud_itab.py, for example to fix #120, have had only the desired effect. Pull request to follow shortly...
martindorey added a commit to martindorey/udis86 that referenced this issue May 10, 2023
@martindorey
Ordering of itab.h and itab.c varies between runs and Python versions v…
63f4469 
…mt#144 (vmt#144)

scripts/ud_opcode.py: Working on vmt#120, because I hadn't realized that someone had already got properly to the root of it, in vmt#139, I was hampered by the output, specifically itab.h, changing order every time I ran:

UD_OPCODE_DEBUG=1 python3 ../scripts/ud_itab.py ../docs/x86/optable.xml .

... from the libudis86/ directory.  The getLabels change here fixes that to be in a defined ordering.

The mergeSSENONE change fixes the ordering differences I see in itab.c between running the above command and similar with python2, by iterating over each table in the same style as used by genOpcodeTable in class UdItabGenerator in scripts/ud_itab.py.
@martindorey martindorey mentioned this issue May 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martindorey