Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary_opcode exposed, but no longer used #103

Open
n1tehawk opened this issue Aug 1, 2015 · 0 comments
Open

primary_opcode exposed, but no longer used #103

n1tehawk opened this issue Aug 1, 2015 · 0 comments

Comments

@n1tehawk
Copy link

n1tehawk commented Aug 1, 2015

struct ud still exposes a member field uint8_t primary_opcode;, but decode_opcode() in decode.c no longer assigns to it.

This might potentially break applications relying on the previous behavior (up to and including release 1.7.2) without further notice.

Suggested solution: Either restore the primary_opcode assignment in decode_opcode(), or remove the field completely, so it's usage would generate compiler warnings. I'd prefer the former, as it involves very little overhead and provides information that could be useful.

Regards, NiteHawk

[EDIT] The related commit is 5cd546f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant