Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate config from Client struct in net.smtp #19928

Open
2 tasks
einar-hjortdal opened this issue Nov 18, 2023 · 0 comments
Open
2 tasks

Separate config from Client struct in net.smtp #19928

einar-hjortdal opened this issue Nov 18, 2023 · 0 comments
Labels
Feature/Enhancement Request This issue is made to request a feature or an enhancement to an existing one.

Comments

@einar-hjortdal
Copy link
Contributor

einar-hjortdal commented Nov 18, 2023

Describe the feature

Currently, a Client struct must be created to configure a new smtp client, the new_client function expects a Client parameter.
The same function also returns a Client struct.
It would be more user friendly for new_client to expect a smtp.Config struct and return a smtp.Client instead.

Use Case

Makes it clearer and easier to use the smtp module.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Version used

Current V version: V 0.4.3 976c5fb, timestamp: 2023-11-18 14:47:04 +0200

Environment details (OS name and version, etc.)

V full version: V 0.4.3 95509cf.976c5fb
OS: linux, Linux version 5.14.0-362.8.1.el9_3.x86_64 (mockbuild@pp-el9) (gcc (GCC) 11.4.1 20230605 (Red Hat 11.4.1-2), GNU ld version 2.35.2-42.el9) #1 SMP PREEMPT_DYNAMIC Tue Nov 7 18:43:14 CET 2023
Processor: 8 cpus, 64bit, little endian, Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz

getwd: /home/coachonko/Documents/projects/vlang/peony
vexe: /home/coachonko/.local/lib64/v/v
vexe mtime: 2023-11-18 15:29:57

vroot: OK, value: /home/coachonko/.local/lib64/v
VMODULES: OK, value: /home/coachonko/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.39.3
Git vroot status: weekly.2023.45.1-76-g976c5fba
.git/config present: true

CC version: cc (GCC) 11.4.1 20230605 (Red Hat 11.4.1-2)
thirdparty/tcc status: thirdparty-linux-amd64 12f392c3

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

@einar-hjortdal einar-hjortdal added the Feature/Enhancement Request This issue is made to request a feature or an enhancement to an existing one. label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature/Enhancement Request This issue is made to request a feature or an enhancement to an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant