Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publication resolver to person #73

Open
outten45 opened this issue Jul 8, 2019 · 4 comments
Open

Add publication resolver to person #73

outten45 opened this issue Jul 8, 2019 · 4 comments
Assignees

Comments

@outten45
Copy link

outten45 commented Jul 8, 2019

Currently, the graphql schema has a minimal nested objects. This would be to add a call to the resolver to get the full publication with (hopefully) all of the pagination and faceting available.

@outten45 outten45 changed the title Add pulbcation resolver to person Add publication resolver to person Jul 8, 2019
@jimwood
Copy link
Collaborator

jimwood commented Jul 29, 2019

An example of this is working in the vstf-73-person-publication-resolver branch. Front-end work can use the 'person' resolver in this branch. This is not ready to merge pending some open questions:

This commit retrieves an accurate list of publications with batched queries:
9dba7cb

This one tries to address those concerns by using a single fetch based on 'syncIds':
aa251bc

This may not be accurate since syncIds may contain person ids for editors or other roles.

The question then is, can role specific id fields be added to the Document schema (authorIds, editorIds)?

Also for discussion, should we limit exposed resolvers for each type to a singular (ie person to fetch the EnhancedPerons with fully resolved associations) and a plural (ie people that allows query, sorting, filtering, faceting, paging on the nested schema) for simplicity? That would handle search/browse pages and entity pages. I started this:

35dd150

But ran out of time and Java knowledge to complete.

@ghost
Copy link

ghost commented Aug 6, 2019

Instead of adding an indexed field of ids for each relationship, a filter can be implemented for the specific desired relationship. In this case, the documents collection is queried for all Solr documents matching the syncIds and filtered by author matching the person.

@ghost
Copy link

ghost commented Aug 6, 2019

@ghost
Copy link

ghost commented Aug 6, 2019

Here is a related issue, #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants