Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vi renderer rather than json for module requests #3

Closed
phorward opened this issue Apr 17, 2023 · 2 comments
Closed

Use vi renderer rather than json for module requests #3

phorward opened this issue Apr 17, 2023 · 2 comments
Assignees
@akelch
Labels
bug Something isn't working
Milestone
Build 2

Comments

@phorward
Copy link
Member

It seems that the new VI expects all modules to have Module.json = True set, as the json renderer seems to be used. This should be changed to the vi renderer as in previous VI versions.
image
@phorward phorward added the bug Something isn't working label Apr 17, 2023
@ArneGudermann
Copy link
Contributor

I think the problem is in https://github.com/viur-framework/viur-vue-utils/blob/main/packages/viur-vue-utils/utils/request.js because this alway use the json Renderer.

@phorward
Copy link
Member Author

I think the problem is in https://github.com/viur-framework/viur-vue-utils/blob/main/packages/viur-vue-utils/utils/request.js because this alway use the json Renderer.

Maybe. This should be parametrizable in viur-vue-utils and default to vi in VI 4.0.0.

@akelch akelch added this to the Build 2 milestone Apr 17, 2023
@akelch akelch closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akelch akelch

Labels
bug Something isn't working
Projects
None yet
Milestone
Build 2
Development

No branches or pull requests
3 participants
@phorward @akelch @ArneGudermann