Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more elements to have a color override in a Style #260

Open
2 of 4 tasks
Morxemplum opened this issue Jul 31, 2020 · 3 comments
Open
2 of 4 tasks

Allow more elements to have a color override in a Style #260

Morxemplum opened this issue Jul 31, 2020 · 3 comments
Assignees

Comments

@Morxemplum
Copy link
Collaborator

Morxemplum commented Jul 31, 2020

I think a nice addition that we can have to styles is the ability to override elements that usually would refer to the "main" color with new color attributes.

Here's a few things that can be overridden (this is the first issue I've raised with a checklist):

  • Player Color
  • Text Color
  • Swap Color
  • Void Color
@Zly-u
Copy link
Collaborator

Zly-u commented Aug 1, 2020

Would add:

  • Individual background panel colours by ID.

sounds like a cool feature to me idk.
If it's for Lua ofc

@Morxemplum
Copy link
Collaborator Author

That is an entire issue on it's own, as it is pertaining to Lua. This issue focuses on the style JSONs themselves.

@Morxemplum
Copy link
Collaborator Author

Updated the issue by adding one more thing: the underlying background (or void, whatever you'd like to call it). Maybe that could be customizable. It may not serve a use 90% of the time, but it would give the Alpha attribute a purpose. I just consider the alpha attribute to be a glorified darkening attribute.

Since 2.0.3, player color and text color overrides are now possible because of #261. Swap color will be interesting. Both swap color and void color are niche, but again, we considered a lot of things in 1.92 niche but turned out to be fairly useful features later on. I'll have to see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants