Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slow test detection #6680

Closed
4 tasks done
JesusTheHun opened this issue Oct 10, 2024 · 5 comments
Closed
4 tasks done

Add slow test detection #6680

JesusTheHun opened this issue Oct 10, 2024 · 5 comments

Comments

@JesusTheHun
Copy link

JesusTheHun commented Oct 10, 2024

Clear and concise description of the problem

The conclusion of #6534 is that slow test detection apply to any top level task within a file.
I use slow test to detect issues in a test design, so detecting a slow suite does not help me since tests can be added to a suite, leading to an increase in the overall time.

I understand that some people use that to make sure the test time is evenly distributed between shards ; that’s not my usage.

Suggested solution

Either a granularity option, or a new option to detect slow test only.

Alternative

No response

Additional context

No response

Validations

@sheremet-va
Copy link
Member

I don't understand the issue. The duration is reported for tests and suites. Don't look at a suite time if you don't need it

@JesusTheHun
Copy link
Author

In the current state of things, slow top-level tasks are reported by highlighting the duration of the task. If a test duration is higher than the threshold, it is not highlighted.

I would like the same highlight at the test level.

@sheremet-va
Copy link
Member

In the current state of things, slow top-level tasks are reported by highlighting the duration of the task. If a test duration is higher than the threshold, it is not highlighted.

It is a bug then, and not a feature request

@sheremet-va
Copy link
Member

And I cannot reproduce it:

Screenshot 2024-10-11 at 12 10 52 Screenshot 2024-10-11 at 12 11 09

Copy link

Hello @JesusTheHun. Please provide a minimal reproduction using a GitHub repository or StackBlitz (you can also use examples). Issues marked with needs reproduction will be closed if they have no activity within 3 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants