Merge pull request #2116 from visualize-admin/fix/sync-text-height

bprusinowski · web-flow · commit 006b6eb4081d · 2025-02-18T15:29:17.000+01:00
fix: Infinite loop when resizing text blocks
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@ You can also check the
 - Fixes
   - Color picker's HEX code input now stays up-to-date with the selected color
   - Markdown links now open in a new tab
+  - Publishing of a dashboard with text blocks doesn't crash the application in
+    some rare cases anymore
 
 # [5.2.5] - 2025-02-18
 
diff --git a/app/configurator/configurator-state/reducer.tsx b/app/configurator/configurator-state/reducer.tsx
@@ -1198,11 +1198,10 @@ const reducer_: Reducer<ConfiguratorState, ConfiguratorStateAction> = (
       if (draft.state === "LAYOUTING" || draft.state === "PUBLISHED") {
         if (!isEqual(draft.layout, action.value)) {
           draft.layout = action.value;
+          ensureDashboardLayoutIsCorrect(draft);
         }
       }
 
-      ensureDashboardLayoutIsCorrect(draft);
-
       return draft;
 
     case "LAYOUT_ACTIVE_FIELD_CHANGED":

Original file line number	Diff line number	Diff line change
`@@ -1198,11 +1198,10 @@ const reducer_: Reducer<ConfiguratorState, ConfiguratorStateAction> = (`
`1198`	`1198`	`if (draft.state === "LAYOUTING" \|\| draft.state === "PUBLISHED") {`
`1199`	`1199`	`if (!isEqual(draft.layout, action.value)) {`
`1200`	`1200`	`draft.layout = action.value;`
	`1201`	`+ ensureDashboardLayoutIsCorrect(draft);`
`1201`	`1202`	`}`
`1202`	`1203`	`}`
`1203`	`1204`
`1204`		`- ensureDashboardLayoutIsCorrect(draft);`
`1205`		`-`
`1206`	`1205`	`return draft;`
`1207`	`1206`
`1208`	`1207`	`case "LAYOUT_ACTIVE_FIELD_CHANGED":`