@@ -7,9 +7,14 @@ const DEFAULT_OPTIONS = {
77const DEFAULT_CONFIG = {
88 extends : [ 'uber-es2015' , 'prettier' , 'prettier/react' , 'plugin:import/errors' ] ,
99 plugins : [ 'import' ] ,
10- parser : 'babel- eslint' ,
10+ parser : '@ babel/ eslint-parser ' ,
1111 parserOptions : {
12- ecmaVersion : 2020
12+ ecmaVersion : 2020 ,
13+ // @babel /eslint-parser issues https://github.com/babel/babel/issues/11975
14+ requireConfigFile : false ,
15+ babelOptions : {
16+ configFile : './babel.config.js'
17+ }
1318 } ,
1419 env : {
1520 // Note: also sets ecmaVersion
@@ -30,44 +35,93 @@ const DEFAULT_CONFIG = {
3035 'import/no-unresolved' : [ 'error' ] ,
3136 'import/no-extraneous-dependencies' : [ 'error' , { devDependencies : false , peerDependencies : true } ]
3237 } ,
38+ settings : {
39+ // Ensure eslint finds typescript files
40+ 'import/resolver' : {
41+ node : {
42+ extensions : [ '.js' , '.jsx' , '.mjs' , '.ts' , '.tsx' , '.d.ts' ]
43+ }
44+ }
45+ } ,
3346 ignorePatterns : [ 'node_modules' , '**/dist*/**/*.js' ] ,
3447 overrides : [
3548 {
3649 // babel-eslint can process TS files, but it doesn't understand types
3750 // typescript-eslint has some more advanced rules with type checking
38- files : [ '**/*.ts' , '**/*.tsx' ] ,
51+ files : [ '**/*.ts' , '**/*.tsx' , '**/*.d.ts' ] ,
3952 parser : '@typescript-eslint/parser' ,
4053 parserOptions : {
4154 sourceType : 'module' , // we want to use ES modules
4255 project : './tsconfig.json'
4356 } ,
4457 plugins : [ '@typescript-eslint' ] ,
4558 rules : {
46- ...typescriptConfigs [ 'eslint-recommended' ] . rules ,
47- ...typescriptConfigs . recommended . rules ,
48- ...typescriptConfigs [ 'recommended-requiring-type-checking' ] . rules ,
59+ // Standard rules
60+
61+ // We still have some issues with import resolution
62+ 'import/named' : 0 ,
63+ 'import/no-extraneous-dependencies' : [ 'warn' ] ,
64+ // Warn instead of error
65+ 'max-params' : [ 'warn' ] ,
66+ 'no-undef' : [ 'warn' ] ,
67+ camelcase : [ 'warn' ] ,
4968 indent : [ 'warn' , 2 , { SwitchCase : 1 } ] ,
5069 quotes : [ 'warn' , 'single' ] ,
5170 'no-process-env' : 'off' ,
52- '@typescript-eslint/no-unused-vars' : [ 'warn' ] ,
53- '@typescript-eslint/no-explicit-any' : 0 ,
54- '@typescript-eslint/switch-exhaustiveness-check' : [ 'error' ] ,
71+
72+ // typescript rules
73+
74+ ...typescriptConfigs [ 'eslint-recommended' ] . rules ,
75+ ...typescriptConfigs . recommended . rules ,
76+ ...typescriptConfigs [ 'recommended-requiring-type-checking' ] . rules ,
77+
5578 // Some of JS rules don't always work correctly in TS and
5679 // hence need to be reimported as TS rules
5780 'no-redeclare' : 'off' ,
58- '@typescript-eslint/no-redeclare' : [ 'warn' ] ,
5981 'no-shadow' : 'off' ,
60- '@typescript-eslint/no-shadow' : [ 'warn' ] ,
6182 'no-use-before-define' : 'off' ,
62- '@typescript-eslint/no-use-before-define' : [ 'error' ] ,
6383 'no-dupe-class-members' : 'off' ,
64- '@typescript-eslint/no-dupe-class-members' : [ 'error' ]
84+
85+ // TODO - These rules are sometimes not found?
86+ // '@typescript-eslint/no-shadow': ['warn'],
87+ // '@typescript-eslint/no-redeclare': ['warn'],
88+
89+ // We use function hoisting to put exports at top of file
90+ '@typescript-eslint/no-use-before-define' : 'off' ,
91+ '@typescript-eslint/no-dupe-class-members' : [ 'error' ] ,
92+
93+ // We encourage explicit typing, e.g `field: string = ''`
94+ '@typescript-eslint/no-inferrable-types' : 'off' ,
95+
96+ '@typescript-eslint/no-empty-interface' : [ 'warn' ] ,
97+ '@typescript-eslint/restrict-template-expressions' : [ 'warn' ] ,
98+ '@typescript-eslint/explicit-module-boundary-types' : [ 'warn' ] ,
99+ '@typescript-eslint/require-await' : [ 'warn' ] ,
100+ '@typescript-eslint/no-unsafe-return' : [ 'warn' ] ,
101+ '@typescript-eslint/no-unsafe-call' : [ 'warn' ] ,
102+
103+ // some day we will hopefully be able to enable this rule
104+ '@typescript-eslint/no-explicit-any' : 'off' ,
105+ '@typescript-eslint/ban-ts-comment' : [ 'warn' ] ,
106+ '@typescript-eslint/ban-types' : [ 'warn' ] ,
107+ '@typescript-eslint/no-unsafe-member-access' : [ 'warn' ] ,
108+ '@typescript-eslint/no-unsafe-assignment' : [ 'warn' ] ,
109+ '@typescript-eslint/no-var-requires' : [ 'warn' ] ,
110+ '@typescript-eslint/no-unused-vars' : [ 'warn' ] ,
111+ '@typescript-eslint/switch-exhaustiveness-check' : [ 'error' ] ,
112+ '@typescript-eslint/no-floating-promises' : [ 'warn' ] ,
113+ '@typescript-eslint/await-thenable' : [ 'warn' ] ,
114+ '@typescript-eslint/no-misused-promises' : [ 'warn' ] ,
115+ '@typescript-eslint/restrict-plus-operands' : [ 'warn' ] ,
116+ '@typescript-eslint/no-empty-function' : [ 'warn' ]
65117 }
66118 } ,
67119 {
68120 // We can lint through code examples in Markdown as well,
69121 // but we don't need to enable all of the rules there
70122 files : [ '**/*.md' ] ,
123+ plugins : [ 'markdown' ] ,
124+ // extends: 'plugin:markdown/recommended',
71125 rules : {
72126 'no-undef' : 'off' ,
73127 'no-unused-vars' : 'off' ,
0 commit comments