Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A password must be supplied for cPanel migrations - make mandatory #927

Open
shoulders opened this issue Oct 18, 2024 · 4 comments
Open

Comments

@shoulders
Copy link

SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.5
Usermin version 2.102
Virtualmin version 7.20.2 Pro
Theme version 21.20.7
Apache version 2.4.52
Package updates 10 package updates are available

the issue

If you do not enter a password for cpanel migrations you get this error

image

proposed solution

Make the password field mandatory when cpanel backup is selected

image

additional

maybe remove the option to try and figure out the password automatically? most backups will have this hashed nowadays (or should).

@jcameron
Copy link
Collaborator

The hashed password isn't good enough in most cases though - Virtualmin needs the original so it can be re-hashed for MySQL or the local /etc/shadow file format.

@shoulders
Copy link
Author

The hashed password isn't good enough in most cases though - Virtualmin needs the original so it can be re-hashed for MySQL or the local /etc/shadow file format.

I should of been more specific, remove work out from backup option because most backups should not have the password present in the archive.

@jcameron
Copy link
Collaborator

In some cases we can get the password from the backup though, so I don't think it would make sense to remove that option entirely.

@shoulders
Copy link
Author

  • defiantly make password mandatory on cPanel because I keep forgetting to add the password, do a large upload and then it says I need a password.
  • I am guessing the new version of Plesk and DirectAdmin will be the same, so perhaps make password mandatory for these aswell.
  • The other imports for dead systems don't need to have any change made to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants