Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color variable definition #26

Open
stefan-korn opened this issue Oct 16, 2024 · 0 comments
Open

color variable definition #26

stefan-korn opened this issue Oct 16, 2024 · 0 comments

Comments

@stefan-korn
Copy link

Custom color variables (i. e. primary color) are defined in default.css.

But this does not make use of the Bootstrap sass variables. Why not override the variables in styles.scss like it is already done for some variables?

This way the css variables for :root would be generated automatically, at least for existing Bootstrap variables. And variables that Bootstrap does deviate from each other will be generated automatically too (which is not the case right now), like for example some border colors or text colors that are based on $primary.

And redundancies like defining --primary and --primary-rgb would be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant