Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No second logo for dark mode #23

Open
stefan-korn opened this issue Oct 14, 2024 · 0 comments
Open

No second logo for dark mode #23

stefan-korn opened this issue Oct 14, 2024 · 0 comments

Comments

@stefan-korn
Copy link

Currently a second logo is used for the dark mode:
https://github.com/virtualidentityag/stadtKoeln-openData-frontend/blob/main/src/partials/base/b_header.twig#L10

We would prefer to have only one logo used, especially as the logos do not differ other than in the color I suppose.

Couldn't we use some CSS styling to color the main logo for dark mode? Maybe CSS something like:

filter: brightness(0) invert(1);

One could maybe also use this in the footer: https://github.com/virtualidentityag/stadtKoeln-openData-frontend/blob/main/src/partials/base/b_footer.twig#L11 - in that case for both dark and light mode.

The reason behind this is, that we do not want to collect a second logo as this is not intended by Drupal and would need some Drupal customization we would rather not want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant