Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider typing #62

Open
cleoold opened this issue Dec 22, 2020 · 3 comments
Open

Consider typing #62

cleoold opened this issue Dec 22, 2020 · 3 comments
Assignees

Comments

@cleoold
Copy link

cleoold commented Dec 22, 2020

Adding type annotations to the library would be helpful for those into type checking. This can avoid type errors.

I can create separate PRs for this as it is simple enough :-) Do you think this is a good idea?

@cleoold
Copy link
Author

cleoold commented Jan 22, 2021

Because I couldn't get the author to reply me :-| I wrapped up my own library that has similar usage to py-enumerable, except it has fully typed interface and really lazy evaluations (e.g. py-enumerable does not support infinite streams).

@viralogic
Copy link
Owner

@cleoold
Apologies for this. I never received a notification that this issue was even created and just noticed this today.

I think this is an acceptable request given that py-enumerable is really only supporting 3.9, 3.8, 3.7 now and typing is already baked in these Python versions. I actually was thinking of doing this myself already actually. I will have a look at your work and attempt to incorporate into py-enumerable.

@viralogic viralogic self-assigned this Apr 27, 2021
@mokeyish
Copy link

https://github.com/jakkes/python-linq has typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants