Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin huggingface_hub version to match with main branch #6

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Pin huggingface_hub version to match with main branch #6

merged 1 commit into from
Jul 19, 2024
+1 −1

Conversation

aahameda
Copy link
Collaborator

What does this PR do ?

Pin huggingface_hub version to match with main branch to avoid ImportError: cannot import name 'ModelFilter' from 'huggingface_hub'. See NVIDIA#9793

@aahameda aahameda changed the base branch from main to v1.21.0_maglev July 19, 2024 11:28
@aahameda aahameda merged commit bd5a549 into v1.21.0_maglev Jul 19, 2024
9 checks passed
@utunga
Copy link

utunga commented Aug 21, 2024

Just a vote +1 on the idea of this PR hitting @nvidia/NeMo

We recently had a breaking stage with our deployment scripts caused by not pinning the huggingface_hub version.

For context this is the comment in the Dockerfile now

# explicitly downgrade to 0.23.2 to avoid breaking changes in 0.24.6 (which gets installed by unpinned dependency in nemo_tookit==1.22.0)
# that is, nemo_toolkit==1.22.0 installs 'huggingface_hub>=0.23.2' which ends up being huggingface_hub==0.24.6 which is not actually compatible with nemo_toolkit==1.22.0 which is what we're using
# cf https://github.com/NVIDIA/NeMo/issues/9793#issuecomment-2237900513. Remove all this when/if we upgrade NeMo
RUN pip install huggingface_hub==0.23.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASR CI common core NLP Speaker Tasks TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aahameda @utunga