Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin deployments to release tags #34

Open
shenanigansd opened this issue Oct 26, 2023 · 2 comments
Open

Pin deployments to release tags #34

shenanigansd opened this issue Oct 26, 2023 · 2 comments
Assignees

Comments

@shenanigansd
Copy link
Member

shenanigansd commented Oct 26, 2023

Now that we're starting to get manageable releases out for our apps, we should start pinning the deployments to the releases to avoid surprises.
I have created #35 to show what this would look like.

@shenanigansd shenanigansd self-assigned this Oct 26, 2023
@Robin5605
Copy link
Contributor

Robin5605 commented Oct 26, 2023

Good idea. However the recommended way is to generally pin to commit hash (see Security Hardening for GitHub Actions) Though this is mostly for third party actions, it wouldn't hurt to be consistent.

I don't think pinning to commit hashes for our own internal releases is too big of a deal but perhaps something worth discussing.

@shenanigansd
Copy link
Member Author

Good idea. However the recommended way is to generally pin to commit hash (see Security Hardening for GitHub Actions)

958484a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants