-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "greylisting" #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nitpicks.
To explain this behavior to ensure we're accomplishing the objective properly:
Package flags should always reference the last seen version of the package to determine whether or not it will flag again. |
The feature @import-pandas-as-numpy needs to be implemented in the |
Previously did not take into account that the query might return `None`, which would happen when the package is the first version.
Removed `is True` check. Changed fstring to normal string.
854cb4a
to
0294f01
Compare
Closing this for now as it seems there was a misunderstanding on what the specification for #61 was. This may yet be a feature we want, and we will re-open it in the future after it's been discussed. Thanks all! |
Closes #61