Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SQL queries to a separate module #300

Closed
jonathan-d-zhang opened this issue Jul 25, 2024 · 1 comment
Closed

Extract SQL queries to a separate module #300

jonathan-d-zhang opened this issue Jul 25, 2024 · 1 comment

Comments

@jonathan-d-zhang
Copy link
Contributor

Currently at least a few DB functions are repeated (looking up a package, for example). Extracting these queries to a separate module will let us deduplicate and isolate (SQL) security issues to one spot.

I think we can do all the queries at once. The amount of refactoring necessary should be smaller, and it will be easier to manage

@jonathan-d-zhang
Copy link
Contributor Author

Now thinking about this again, it doesn't make sense to have it separate from #295.

@jonathan-d-zhang jonathan-d-zhang closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant