Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Definitions to new setFactory methods #24

Open
ghost opened this issue Aug 7, 2015 · 1 comment
Open

Update Service Definitions to new setFactory methods #24

ghost opened this issue Aug 7, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 7, 2015

Currently trying to use the extension with post Symfony 2.6 dependencies breaks it due to the error:

The error "Symfony\Component\DependencyInjection\Definition::setFactoryService(vipsoft.code_coverage.driver.factory) is deprecated since version 2.
6 and will be removed in 3.0. Use Definition::setFactory() instead."

It would be nice if you could update the services.xml to use the updated definitions and support Symfony 2.6+. I am not familiar with XML definitions to issue a PR myself.

@ek9
Copy link

ek9 commented Apr 5, 2017

In case you are coming back to this in the future, I have fixed it in a forked version of the package, changes in the commit: leanphp/behat-code-coverage@371c44c#diff-09af2b221d2475b568160a53310abe2aL63
(I am maintaining the fork to keep compatibility with both versions of Symfony until 2.8 LTS is maintained, so I kept support for older service definitions too). Hope this is any helpful for those looking for a fix (or you can alternatively give it a go to a leanphp/behat-code-coverage (which is a fork of this)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant