Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Incorrect job_pool_nerrors in the echo off mode #4

Open
martinjansa opened this issue Nov 25, 2017 · 1 comment
Open

Minor: Incorrect job_pool_nerrors in the echo off mode #4

martinjansa opened this issue Nov 25, 2017 · 1 comment

Comments

@martinjansa
Copy link

Hi,

I am playing with the sample ./job_pool_sample.sh and have noticed that it dumps job_pool_nerrors: 0 by default when the job pool is created in non-echo mode, even though there are two jobs that fail (return false). In the interactive mode (echo on) it correctly dumps 2 failures.

The problem seems to be in the _job_pool_worker(), where the _job_pool_print_result_log() is used to log the result into the log file and which does nothing for the non-echo mode.

I can provide a pull request with the fix, if helpful (changing to plain echo and adding echo on condition into the _job_pool_print_result_log().

Regards,,

Martin

@martinjansa
Copy link
Author

shellutils_issue4_fix.diff.txt
DIff with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant