Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Germany' used inconsistently as value for country.name.en #328

Open
smoser11 opened this issue May 24, 2023 · 1 comment
Open

'Germany' used inconsistently as value for country.name.en #328

smoser11 opened this issue May 24, 2023 · 1 comment

Comments

@smoser11
Copy link

Howdy. I'm sorry if I'm being dense, but why are West Germany ( German Federal Republic , cown= 260) given the same English -- and German -- name of post-unification Germany (Germany, cown = 255) ? This seems to introduce unnecessary ambiguity in the codelist_panel data included in the package. The countrycode package does (correctly) treat East Germany (German Democratic Republic, cown = 265) separate from 'Germany.'

Is there a reason for this?
@vincentarelbundock
Copy link
Owner

vincentarelbundock commented May 24, 2023 •
edited
Loading

The panel build script is here: https://github.com/vincentarelbundock/countrycode/blob/main/dictionary/build.R#L68

I'd be happy to merge a pull request if you have improvements to suggest. ;-)

@vincentarelbundock vincentarelbundock changed the title 'Germany' used inconcistantly as value for country.name.en 'Germany' used inconsistently as value for country.name.en May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentarelbundock @smoser11