Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhyCell_Cell code is different comparing to the paper #25

Open
sippeyxp opened this issue Sep 17, 2021 · 1 comment
Open

PhyCell_Cell code is different comparing to the paper #25

sippeyxp opened this issue Sep 17, 2021 · 1 comment

Comments

@sippeyxp
Copy link

In paper K is a function of h_tilde_t and E(u_t).

In code, the implementation is

24 combined = torch.cat([x, hidden], dim=1) # concatenate along channel axis
25 combined_conv = self.convgate(combined)
26 K = torch.sigmoid(combined_conv)

On line 24, it should be torch.cat([x, hidden_tilde, dim=1) ?

@lf-demo
Copy link

lf-demo commented Jan 11, 2023

I have the same question with you at first. But i find that the detail of experiment is recorded in the supplementary. Here is the link https://openaccess.thecvf.com/content_CVPR_2020/supplemental/Le_Guen_Disentangling_Physical_Dynamics_CVPR_2020_supplemental.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants