From bb10f13e887ee21dd87acb746dbf53188755aabf Mon Sep 17 00:00:00 2001 From: Patrick Remy Date: Tue, 23 Jan 2024 22:13:52 +0100 Subject: [PATCH] docs: simplify TaintBadDataPlugin example again --- docs/security_analysis/custom_taint_sources.md | 6 +++--- .../Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/security_analysis/custom_taint_sources.md b/docs/security_analysis/custom_taint_sources.md index 776e99ef9e1..938bd3455ba 100644 --- a/docs/security_analysis/custom_taint_sources.md +++ b/docs/security_analysis/custom_taint_sources.md @@ -44,11 +44,11 @@ class TaintBadDataPlugin implements AddTaintsInterface { $expr = $event->getExpr(); - if (!$expr instanceof Variable) { - return []; + if ($expr instanceof Variable && $expr->name === 'bad_data') { + return TaintKindGroup::ALL_INPUT; } - return $expr->name === 'bad_data' ? TaintKindGroup::ALL_INPUT : []; + return []; } } ``` diff --git a/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php b/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php index b5047ebaf4f..437eb6fd4c6 100644 --- a/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php +++ b/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php @@ -21,10 +21,10 @@ public static function addTaints(AddRemoveTaintsEvent $event): array { $expr = $event->getExpr(); - if (!$expr instanceof Variable) { - return []; + if ($expr instanceof Variable && $expr->name === 'bad_data') { + return TaintKindGroup::ALL_INPUT; } - return $expr->name === 'bad_data' ? TaintKindGroup::ALL_INPUT : []; + return []; } }