chore: use --enable=all in shellcheck (#88)

* chore: use --enable=all in shellcheck

* style: use -exec on results of find

* style: use ||

* style: linting

* style: use -exec in find

Author: vil02

check_all_python_scripts.sh

@@ -2,32 +2,4 @@
 
 set -euo pipefail
 
-function check_single()
-{
-    declare -r in_path="$1"
-    declare -i result_val=0
-    printf "Checking \"%s\"\n" "${in_path}"
-    printf "Checking with pylint:\n"
-    if ! poetry run pylint "$in_path" ; then
-        result_val=1
-    fi
-
-    printf "Checking with flake8:\n"
-    if ! poetry run flake8 "$in_path" --count --max-line-length=80 --show-source ; then
-        result_val=1
-    fi
-    printf "...done\n\n\n"
-    return $result_val
-}
-
-
-declare -i exit_code=0
-
-while IFS="" read -r cur_script
-do
-    if ! check_single "$cur_script" ; then
-        exit_code=1
-    fi
-done < <(find . -name "*.py" -not -path "./tests/example_data/python3/*")
-
-exit $exit_code
+find . -name "*.py" -not -path "./tests/example_data/python3/*" -exec ./check_python_file.sh {} +

check_all_shell_scripts.sh

@@ -2,18 +2,4 @@
 
 set -euo pipefail
 
-declare -i exit_code=0
-
-while IFS="" read -r cur_script
-do
-  printf "Checking \"%s\"\n" "${cur_script}"
-    if ! shellcheck "$cur_script"; then
-      exit_code=1
-    fi
-    if ! grep -q "set -euo pipefail" "$cur_script"; then
-      printf "add \"set -euo pipefail\"\n"
-      exit_code=1
-    fi
-done < <(find . -name "*.sh")
-
-exit $exit_code
+find . -name "*.sh" -exec ./check_shell_script.sh {} +

check_python_file.sh

@@ -0,0 +1,25 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+declare -i exit_code=0
+
+for cur_file in "$@"
+do
+    printf "Checking \"%s\"\n" "${cur_file}"
+    printf "Checking with pylint:\n"
+    if ! poetry run pylint "${cur_file}" ; then
+        exit_code=1
+    fi
+
+    printf "Checking with flake8:\n"
+    if ! poetry run flake8 "${cur_file}" --count --max-line-length=80 --show-source ; then
+        exit_code=1
+    fi
+done
+
+if [[ ${exit_code} -eq 0 ]] ; then
+   printf "\nNo errors found!\n"
+fi
+
+exit "${exit_code}"

check_shell_script.sh

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+declare -i exit_code=0
+
+for cur_script in "$@"
+do
+    printf "Checking \"%s\"\n" "${cur_script}"
+    if ! shellcheck "${cur_script}" --enable=all; then
+      exit_code=1
+    fi
+    if ! grep -q "set -euo pipefail" "${cur_script}"; then
+      printf "add \"set -euo pipefail\"\n"
+      exit_code=1
+    fi
+done
+
+if [[ ${exit_code} -eq 0 ]] ; then
+   printf "\nNo errors found!\n"
+fi
+exit "${exit_code}"

examples/run_all_examples.sh

@@ -2,7 +2,4 @@
 
 set -euo pipefail
 
-while IFS="" read -r cur_script
-do
-    python3 "$cur_script"
-done < <(find . -name "example_*.py")
+find . -name "example_*.py" -exec ./run_python_file.sh {} +

examples/run_python_file.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+declare -i exit_code=0
+
+for cur_file in "$@"
+do
+    if ! poetry run python3 "${cur_file}" ; then
+        exit_code=1
+    fi
+done
+
+if [[ ${exit_code} -eq 0 ]] ; then
+   printf "\nNo errors found!\n"
+fi
+
+exit "${exit_code}"

system_setup_scripts/install_all.sh

@@ -2,7 +2,5 @@
 
 set -euo pipefail
 
-while IFS="" read -r cur_script
-do
-    ./"$cur_script"
-done < <(find . -name "setup_for_*.sh")
+
+find . -name "setup_for_*.sh" -exec ./{} \;

validate_codecov_yml.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 
 status=$(curl -s -X POST --data-binary @codecov.yml https://codecov.io/validate)
 printf "%s\n" "${status}"
-if [[ $status == *Error* ]];
+if [[ ${status} == *Error* ]];
 then
     exit 1
 fi