Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Preview for CLI Migration #2057

Closed
rtritto opened this issue Jan 10, 2025 · 1 comment
Closed

[Doc] Preview for CLI Migration #2057

rtritto opened this issue Jan 10, 2025 · 1 comment
Labels

Comments

@rtritto
Copy link
Contributor

rtritto commented Jan 10, 2025

Description

Before Vike CLI, the vite preview command isn't supported (#2010 (comment)) and node dist/server/index.mjs command must be used.

Using vike preview by CLI Migration page, that command still not supported.

node dist/server/index.mjs doesn't need any CLI (vite or vike)

Alternatives for doc

  1. Nothing is changed (no migration needed).
    Diffs to fix doc:
    - -    "preview": "vite preview"
    - +    "preview": "vike preview"
    +      "preview": "node dist/server/index.mjs"
  2. (preferred) Vike CLI uses the preview command (that call node dist/server/index.mjs) and could do other things.
    The [@brillout/vite-plugin-server-entry] Cannot find server entry #2010 (comment) should be reverted.
    Diffs to fix doc:
    - -    "preview": "vite preview"
    + -    "preview": "node dist/server/index.mjs"
     +   "preview": "vike preview"
@brillout
Copy link
Member

👍 We could do this: vikejs/vike-node#41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants