Automatically set stream: 'web'

[brillout]

To avoid this error: #30.

See https://vike.dev/stream.

Let's do this after we make vike-node a Vike extension.

Note

It's currently a Vite plugin and not a Vike extension. We'll be able to make it a Vike extension after we implemented the Vike CLI.

Edit: instead of using stream let's create a new settting streamType: 'node' | 'web', so that the user can still enable/disable streaming.

[magne4000]

Is this still relevant?

[brillout]

Yea, I think so: universal-middleware and thus vike-server both don't supports Node.js streams?

[magne4000]

I'm wondering if this fix could have made the current issue deprecated.
If not, Vike could auto convert from one type of stream to the other automatically IMO, thus avoiding the need to specify the stream type manually.

[brillout]

Correct me if I'm wrong but I don't think we can convert a Node.js stream to a Web stream.

Fundamentally, universal-middleware forces vike-{react,vue,solid} to create a Web stream instead of a Node.js stream.

[magne4000]

Correct me if I'm wrong but I don't think we can convert a Node.js stream to a Web stream.

We can, there even is a native way to do it with Readable.toWeb

[brillout]

Oh, nice, ok we can try that then 👌

[brillout]

One drawback is that it's labeled as experimental and, in general, it may cause issues? Do we strictly need to convert? Maybe it would be wiser to tell vike-{react,vue,solid} to create a Web stream instead of a Node.js stream.

[magne4000]

I wouldn't worry to much about it being experimental, it has been here for multiple years now.
I also agree that we should try to create the right type of stream to begin with, and such conversion could just be a fallback then.

[brillout]

👍

[brillout]

Streams are quite complex, so I'd even say there is a risk implementing a fallback disincentivizes doing it right. If there is a use case for falling back it's good to know we can.