You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #203 addresses #84 when no sufficient extrema are not found and we can not build interpolants through the pericenters and apocenters. However, there would be cases where we can find enough extrema in the initial part of the waveform and therefore build the interpolants but due to decay of eccentricity the last pericenters/apocenters may be far from the merger. In such cases, if tref_in is later than the last pericenters/apocenters, eccentricity measurement will fail. We need to handle such failures also.
The text was updated successfully, but these errors were encountered:
PR #203 addresses #84 when no sufficient extrema are not found and we can not build interpolants through the pericenters and apocenters. However, there would be cases where we can find enough extrema in the initial part of the waveform and therefore build the interpolants but due to decay of eccentricity the last pericenters/apocenters may be far from the merger. In such cases, if
tref_in
is later than the lastpericenters/apocenters
, eccentricity measurement will fail. We need to handle such failures also.The text was updated successfully, but these errors were encountered: