Skip to content

Commit 80d8714

Browse files
committed
Fix tests
1 parent ce3692d commit 80d8714

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

jquery.jmapping.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,10 @@
5353
});
5454

5555
if (doUpdate){
56-
zoom_level = map.getZoom();
57-
min_zoom = (zoom_level < 7) ? 0 : (zoom_level - 7);
58-
markerManager.addMarkers(gmarkersArray(), min_zoom);
59-
markerManager.refresh();
56+
updateMarkerManager();
6057
} else {
6158
google.maps.event.addListener(markerManager, 'loaded', function(){
62-
zoom_level = map.getZoom();
63-
min_zoom = (zoom_level < 7) ? 0 : (zoom_level - 7);
64-
markerManager.addMarkers(gmarkersArray(), min_zoom);
65-
markerManager.refresh();
59+
updateMarkerManager();
6660
});
6761
}
6862

@@ -197,6 +191,13 @@
197191
return marker;
198192
};
199193

194+
var updateMarkerManager = function(){
195+
zoom_level = map.getZoom();
196+
min_zoom = (zoom_level < 7) ? 0 : (zoom_level - 7);
197+
markerManager.addMarkers(gmarkersArray(), min_zoom);
198+
markerManager.refresh();
199+
};
200+
200201
var attachMapsEventToLinks = function(){
201202
var location_link_selector = [
202203
settings.side_bar_selector,

spec/spec_helper.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ Screw.Specifications.mockGMapsUpdate = function(){
6060
// mock out GMap2
6161
var gmap_mock = Smoke.Mock();
6262
gmap_mock.should_receive('fitBounds').exactly('twice');
63+
gmap_mock.should_receive('getZoom').exactly('once').and_return(10);
6364
$.extend(google.maps.Map.prototype, gmap_mock);
6465

6566
// mock out Bounds
@@ -82,6 +83,8 @@ Screw.Specifications.mockMarkerManager = function(update){
8283
var markermanager_mock = Smoke.Mock();
8384
if (update){
8485
markermanager_mock.should_receive('clearMarkers').exactly('once');
86+
markermanager_mock.should_receive('addMarkers').exactly('once');
87+
markermanager_mock.should_receive('refresh').exactly('once');
8588
}
8689

8790
MarkerManager = Smoke.MockFunction(function(map, options){}, 'MarkerManager');

0 commit comments

Comments
 (0)