Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify SDK 23 beta #7

Open
moooji opened this issue Sep 23, 2016 · 6 comments
Open

Spotify SDK 23 beta #7

moooji opened this issue Sep 23, 2016 · 6 comments

Comments

@moooji
Copy link

moooji commented Sep 23, 2016

Spotify has just released SDK 23 beta and it would be great to support that. It looks like a lot of things have changed though.

SDK is now grouped into Authentication, Metadata and AudioPlayback functionality modules independent from each other. This functionality grouping is reflected in the "Spotify.h" header. SDK will be split into three libraries representing these functionality modules in an upcoming release.
Decoupling manifested in that all methods concerning Metadata that previously took a SPTSession object now instead take an NSString *accessToken argument which is a property of the SPTSession object.

@moooji
Copy link
Author

moooji commented Sep 24, 2016

I have refactored most parts now so that it works with SDK 23 beta. If you are interested, my current progress can be seen here. I will send a PR, once the README has been updated and I am sure that everything is stable.

https://github.com/moooji/react-native-spotify/tree/sdk-23

@digitaldavenyc
Copy link

digitaldavenyc commented Sep 30, 2016

@moooji @viestat Upgrading the Spotify SDK is actually a pretty critical issue now for this repo. Apple will reject any submissions using a Spotify SDK lower then v20. Apple now requires support for IPV6 and SDK 20 introduced this support. There is a closed issue with Spotify that has this documented, https://github.com/spotify/ios-sdk/issues/676.

react-native-spotify being on SDK 17, is not capable of submitting to the App Store.

I am working with an iOS developer to upgrade our version of the SDK to v20 so we will be able to submit in the meantime.

@digitaldavenyc
Copy link

@moooji What areas on your fork still require further work to submit a PR?

@ufmemo
Copy link

ufmemo commented Dec 10, 2016

I'm also keenly interested in seeing this updated to the newer version -- looks like beta-25 was released a couple weeks after the last post here. I would be happy to contribute some time on this, testing documenting, etc.

@digitaldavenyc
Copy link

Any ETA on this?

@digitaldavenyc
Copy link

digitaldavenyc commented May 11, 2017

@viestat Not sure if you are still aware but this library is not able to published to the App Store as is without an updating Spotify's SDK

https://github.com/spotify/ios-sdk/issues/676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants