New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`Data.Trie.Map.appendWith` is slow #8

Open

viercc opened this issue Apr 7, 2023 · 0 comments

Owner

viercc commented Apr 7, 2023 •

edited

Loading

Benchmark result

TMap/combine/append                      mean 821.0 ms  ( +- 37.10 ms  )
Map/combine/append                       mean 383.4 ms  ( +- 22.54 ms  )

This hasn't been noticed because of wrong strictness. (cf. ba8d474)

append of TSet is fine.

TSet/combine/append                      mean 624.6 μs  ( +- 67.32 μs  )
Set/combine/append                       mean 241.8 ms  ( +- 28.64 ms  )
TSet_URI/combine/append                  mean 630.3 μs  ( +- 56.01 μs  )
Set_URI/combine/append                   mean 253.2 ms  ( +- 22.39 ms  )

The text was updated successfully, but these errors were encountered:

viercc changed the title ~~append is slow~~ Data.Trie.Map.appendWith is slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment