feat(slo): update preview data API to show groups (elastic#211801)

Author: kdelemme

x-pack/platform/packages/shared/kbn-slo-schema/src/rest_specs/routes/get_preview_data.ts

@@ -6,7 +6,7 @@
  */
 import * as t from 'io-ts';
 import { indicatorSchema, objectiveSchema } from '../../schema';
-import { allOrAnyStringOrArray, dateType } from '../../schema/common';
+import { dateType, groupingsSchema } from '../../schema/common';
 
 const getPreviewDataParamsSchema = t.type({
   body: t.intersection([
@@ -19,32 +19,36 @@ const getPreviewDataParamsSchema = t.type({
     }),
     t.partial({
       objective: objectiveSchema,
-      instanceId: t.string,
-      groupBy: allOrAnyStringOrArray,
       remoteName: t.string,
-      groupings: t.record(t.string, t.unknown),
+      groupings: groupingsSchema,
+      groupBy: t.array(t.string),
     }),
   ]),
 });
 
-const getPreviewDataResponseSchema = t.array(
-  t.intersection([
-    t.type({
-      date: dateType,
-      sliValue: t.union([t.number, t.null]),
+const previewDataResponseSchema = t.intersection([
+  t.type({
+    date: dateType,
+    sliValue: t.union([t.number, t.null]),
+  }),
+  t.partial({
+    events: t.type({
+      good: t.number,
+      bad: t.number,
+      total: t.number,
     }),
-    t.partial({
-      events: t.type({
-        good: t.number,
-        bad: t.number,
-        total: t.number,
-      }),
-    }),
-  ])
-);
+  }),
+]);
+
+const getPreviewDataResponseSchema = t.intersection([
+  t.type({
+    results: t.array(previewDataResponseSchema),
+  }),
+  t.partial({ groups: t.record(t.string, t.array(previewDataResponseSchema)) }),
+]);
 
 type GetPreviewDataParams = t.TypeOf<typeof getPreviewDataParamsSchema.props.body>;
 type GetPreviewDataResponse = t.OutputOf<typeof getPreviewDataResponseSchema>;
 
-export { getPreviewDataParamsSchema, getPreviewDataResponseSchema };
+export { getPreviewDataParamsSchema, getPreviewDataResponseSchema, previewDataResponseSchema };
 export type { GetPreviewDataParams, GetPreviewDataResponse };

x-pack/platform/plugins/private/translations/translations/fr-FR.json

@@ -40005,7 +40005,6 @@
     "xpack.slo.burnRateRuleEditor.h5.defineMultipleBurnRateLabel": "Définir des fenêtres du taux d'avancement multiples",
     "xpack.slo.burnRates.value": "{value} fois",
     "xpack.slo.create.errorNotification": "Un problème est survenu lors de la création de {name}",
-    "xpack.slo.dataPreviewChart.noResultsLabel": "aucun résultat",
     "xpack.slo.deleteConfirmationModal.cancelButtonLabel": "Annuler",
     "xpack.slo.deleteConfirmationModal.deleteAllButtonLabel": "Supprimer le SLO et toutes les instances",
     "xpack.slo.deleteConfirmationModal.deleteButtonLabel": "Supprimer",
@@ -40336,14 +40335,10 @@
     "xpack.slo.sloEdit.customKql.dataViewSelection.label": "Sélectionner une vue de données",
     "xpack.slo.sloEdit.customKql.indexSelection.label": "Index",
     "xpack.slo.sloEdit.customMetric.aggregationLabel": "Agrégation",
-    "xpack.slo.sloEdit.dataPreviewChart.badEvents": "Total des événements",
     "xpack.slo.sloEdit.dataPreviewChart.errorMessage": "Les paramètres d'indicateur actuels ne sont pas valides",
     "xpack.slo.sloEdit.dataPreviewChart.explanationMessage": "Remplir les champs d'indicateur pour visualiser les indicateurs actuels",
-    "xpack.slo.sloEdit.dataPreviewChart.goodEvents": "Bons événements",
     "xpack.slo.sloEdit.dataPreviewChart.moreThan100": "Certaines des valeurs SLI sont supérieures à 100 %. Cela signifie qu'une bonne requête renvoie plus de résultats que la requête totale.",
     "xpack.slo.sloEdit.dataPreviewChart.panelLabel": "Aperçu du SLI",
-    "xpack.slo.sloEdit.dataPreviewChart.syntheticsAvailability.xTitle": "Dernières 24 heures",
-    "xpack.slo.sloEdit.dataPreviewChart.xTitle": "Dernière heure",
     "xpack.slo.sloEdit.dataPreviewChart.yTitle": "SLI",
     "xpack.slo.sloEdit.definition.sliType": "Choisir le type de SLI",
     "xpack.slo.sloEdit.definition.title": "Définir un SLI",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

@@ -39864,7 +39864,6 @@
     "xpack.slo.burnRateRuleEditor.h5.defineMultipleBurnRateLabel": "複数のバーンレート時間枠を定義",
     "xpack.slo.burnRates.value": "{value}x",
     "xpack.slo.create.errorNotification": "{name}の作成中に問題が発生しました",
-    "xpack.slo.dataPreviewChart.noResultsLabel": "結果なし",
     "xpack.slo.deleteConfirmationModal.cancelButtonLabel": "キャンセル",
     "xpack.slo.deleteConfirmationModal.deleteAllButtonLabel": "SLOとすべてのインスタンスを削除",
     "xpack.slo.deleteConfirmationModal.deleteButtonLabel": "削除",
@@ -40194,14 +40193,10 @@
     "xpack.slo.sloEdit.customKql.dataViewSelection.label": "データビューを選択",
     "xpack.slo.sloEdit.customKql.indexSelection.label": "インデックス",
     "xpack.slo.sloEdit.customMetric.aggregationLabel": "アグリゲーション",
-    "xpack.slo.sloEdit.dataPreviewChart.badEvents": "全てのイベント",
     "xpack.slo.sloEdit.dataPreviewChart.errorMessage": "現在のインジケーター設定は無効です",
     "xpack.slo.sloEdit.dataPreviewChart.explanationMessage": "インジケーターフィールドに入力すると、現在のメトリックが可視化されます。",
-    "xpack.slo.sloEdit.dataPreviewChart.goodEvents": "良好なイベント数",
     "xpack.slo.sloEdit.dataPreviewChart.moreThan100": "SLI値の一部が100%を超えています。つまり、質の高いクエリーは合計クエリーよりも多くの結果を返しています。",
     "xpack.slo.sloEdit.dataPreviewChart.panelLabel": "SLIプレビュー",
-    "xpack.slo.sloEdit.dataPreviewChart.syntheticsAvailability.xTitle": "過去 24 時間",
-    "xpack.slo.sloEdit.dataPreviewChart.xTitle": "過去 1 時間",
     "xpack.slo.sloEdit.dataPreviewChart.yTitle": "SLI",
     "xpack.slo.sloEdit.definition.sliType": "SLIタイプを選択",
     "xpack.slo.sloEdit.definition.title": "SLIを定義",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

@@ -39289,7 +39289,6 @@
     "xpack.slo.burnRateRuleEditor.h5.defineMultipleBurnRateLabel": "定义多个消耗速度窗口",
     "xpack.slo.burnRates.value": "{value} 倍",
     "xpack.slo.create.errorNotification": "创建 {name} 时出现问题",
-    "xpack.slo.dataPreviewChart.noResultsLabel": "无结果",
     "xpack.slo.deleteConfirmationModal.cancelButtonLabel": "取消",
     "xpack.slo.deleteConfirmationModal.deleteAllButtonLabel": "删除 SLO 和所有实例",
     "xpack.slo.deleteConfirmationModal.deleteButtonLabel": "删除",
@@ -39618,14 +39617,10 @@
     "xpack.slo.sloEdit.customKql.dataViewSelection.label": "选择数据视图",
     "xpack.slo.sloEdit.customKql.indexSelection.label": "索引",
     "xpack.slo.sloEdit.customMetric.aggregationLabel": "聚合",
-    "xpack.slo.sloEdit.dataPreviewChart.badEvents": "事件合计",
     "xpack.slo.sloEdit.dataPreviewChart.errorMessage": "当前指标设置无效",
     "xpack.slo.sloEdit.dataPreviewChart.explanationMessage": "填写指标字段以查看当前指标的可视化",
-    "xpack.slo.sloEdit.dataPreviewChart.goodEvents": "良好事件",
     "xpack.slo.sloEdit.dataPreviewChart.moreThan100": "某些 SLI 值大于 100%。这表明良好查询返回的结果比总体查询更多。",
     "xpack.slo.sloEdit.dataPreviewChart.panelLabel": "SLI 预览",
-    "xpack.slo.sloEdit.dataPreviewChart.syntheticsAvailability.xTitle": "过去 24 小时",
-    "xpack.slo.sloEdit.dataPreviewChart.xTitle": "过去一小时",
     "xpack.slo.sloEdit.dataPreviewChart.yTitle": "SLI",
     "xpack.slo.sloEdit.definition.sliType": "选择 SLI 类型",
     "xpack.slo.sloEdit.definition.title": "定义 SLI",

x-pack/solutions/observability/plugins/slo/public/components/good_bad_events_chart/good_bad_events_chart.tsx

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import type { Indicator } from '@kbn/slo-schema';
+import type { Indicator, Objective } from '@kbn/slo-schema';
 
 interface SloListFilter {
   kqlQuery: string;
@@ -61,11 +61,17 @@ export const sloKeys = {
     instanceId: string | undefined,
     windows: Array<{ name: string; duration: string }>
   ) => [...sloKeys.all, 'burnRates', sloId, instanceId, windows] as const,
-  preview: (
-    indicator: Indicator,
-    range: { from: Date; to: Date },
-    groupings?: Record<string, unknown>
-  ) => [...sloKeys.all, 'preview', indicator, range, groupings] as const,
+  preview: (params: {
+    remoteName?: string;
+    groupings?: Record<string, string | number>;
+    objective?: Objective;
+    indicator: Indicator;
+    range: {
+      from: Date;
+      to: Date;
+    };
+    groupBy?: string[];
+  }) => [...sloKeys.all, 'preview', params] as const,
   burnRateRules: (search: string) => [...sloKeys.all, 'burnRateRules', search],
   groupings: (params: {
     sloId: string;