Skip to content

Commit d744538

Browse files
kdelemmekdelemme
authored
chore(slo): replace error log level with debug (elastic#212975)
## Summary Resolves elastic#212972 This PR replaces the info and error log levels with debug since most of these errors are for developers or users. Not operations.
1 parent 647a183 commit d744538

File tree

12 files changed

+43
-59
lines changed

12 files changed

+43
-59
lines changed

‎x-pack/solutions/observability/plugins/slo/server/services/create_slo.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,15 @@ export class CreateSLO {
100100
this.summaryTransformManager.start(summaryTransformId),
101101
]);
102102
} catch (err) {
103-
this.logger.error(
103+
this.logger.debug(
104104
`Cannot create the SLO [id: ${slo.id}, revision: ${slo.revision}]. Rolling back. ${err}`
105105
);
106106

107107
await asyncForEach(rollbackOperations.reverse(), async (operation) => {
108108
try {
109109
await operation();
110110
} catch (rollbackErr) {
111-
this.logger.error(`Rollback operation failed. ${rollbackErr}`);
111+
this.logger.debug(`Rollback operation failed. ${rollbackErr}`);
112112
}
113113
});
114114

‎x-pack/solutions/observability/plugins/slo/server/services/reset_slo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class ResetSLO {
8686
{ logger: this.logger }
8787
);
8888
} catch (err) {
89-
this.logger.error(
89+
this.logger.debug(
9090
`Cannot reset the SLO [id: ${slo.id}, revision: ${slo.revision}]. Rolling back. ${err}`
9191
);
9292

‎x-pack/solutions/observability/plugins/slo/server/services/resource_installer.ts

+9-25
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class DefaultResourceInstaller implements ResourceInstaller {
4242
try {
4343
installTimeout = setTimeout(() => (this.isInstalling = false), 60000);
4444

45-
this.logger.info('Installing SLO shared resources');
45+
this.logger.debug('Installing SLO shared resources');
4646
await Promise.all([
4747
this.createOrUpdateComponentTemplate(SLI_MAPPINGS_TEMPLATE),
4848
this.createOrUpdateComponentTemplate(SLI_SETTINGS_TEMPLATE),
@@ -71,9 +71,9 @@ export class DefaultResourceInstaller implements ResourceInstaller {
7171
this.esClient
7272
);
7373
if (template._meta?.version && currentVersion === template._meta.version) {
74-
this.logger.info(`SLO component template found with version [${template._meta.version}]`);
74+
this.logger.debug(`SLO component template found with version [${template._meta.version}]`);
7575
} else {
76-
this.logger.info(`Installing SLO component template [${template.name}]`);
76+
this.logger.debug(`Installing SLO component template [${template.name}]`);
7777
return this.execute(() => this.esClient.cluster.putComponentTemplate(template));
7878
}
7979
}
@@ -86,9 +86,9 @@ export class DefaultResourceInstaller implements ResourceInstaller {
8686
);
8787

8888
if (template._meta?.version && currentVersion === template._meta.version) {
89-
this.logger.info(`SLO index template found with version [${template._meta.version}]`);
89+
this.logger.debug(`SLO index template found with version [${template._meta.version}]`);
9090
} else {
91-
this.logger.info(`Installing SLO index template [${template.name}]`);
91+
this.logger.debug(`Installing SLO index template [${template.name}]`);
9292
return this.execute(() => this.esClient.indices.putIndexTemplate(template));
9393
}
9494
}
@@ -114,19 +114,11 @@ async function fetchComponentTemplateVersion(
114114
esClient: ElasticsearchClient
115115
) {
116116
const getTemplateRes = await retryTransientEsErrors(
117-
() =>
118-
esClient.cluster.getComponentTemplate(
119-
{
120-
name,
121-
},
122-
{
123-
ignore: [404],
124-
}
125-
),
117+
() => esClient.cluster.getComponentTemplate({ name }, { ignore: [404] }),
126118
{ logger }
127119
);
128120

129-
return getTemplateRes?.component_templates?.[0]?.component_template?._meta?.version || null;
121+
return getTemplateRes?.component_templates?.[0]?.component_template?._meta?.version ?? null;
130122
}
131123

132124
async function fetchIndexTemplateVersion(
@@ -135,17 +127,9 @@ async function fetchIndexTemplateVersion(
135127
esClient: ElasticsearchClient
136128
) {
137129
const getTemplateRes = await retryTransientEsErrors(
138-
() =>
139-
esClient.indices.getIndexTemplate(
140-
{
141-
name,
142-
},
143-
{
144-
ignore: [404],
145-
}
146-
),
130+
() => esClient.indices.getIndexTemplate({ name }, { ignore: [404] }),
147131
{ logger }
148132
);
149133

150-
return getTemplateRes?.index_templates?.[0]?.index_template?._meta?.version || null;
134+
return getTemplateRes?.index_templates?.[0]?.index_template?._meta?.version ?? null;
151135
}

‎x-pack/solutions/observability/plugins/slo/server/services/slo_repository.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export class KibanaSavedObjectsSLORepository implements SLORepository {
166166
});
167167

168168
if (isLeft(result)) {
169-
this.logger.error(`Invalid stored SLO with id [${storedSLO.id}]`);
169+
this.logger.debug(`Invalid stored SLO with id [${storedSLO.id}]`);
170170
return undefined;
171171
}
172172

‎x-pack/solutions/observability/plugins/slo/server/services/summary_search_client/summary_search_client.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ export class DefaultSummarySearchClient implements SummarySearchClient {
160160
}),
161161
};
162162
} catch (err) {
163-
this.logger.error(`Error while searching SLO summary documents. ${err}`);
163+
this.logger.debug(`Error while searching SLO summary documents. ${err}`);
164164
return { total: 0, ...pagination, results: [] };
165165
}
166166
}

‎x-pack/solutions/observability/plugins/slo/server/services/summay_transform_manager.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
3232
}
3333
);
3434
} catch (err) {
35-
this.logger.error(`Cannot create summary transform for SLO [${slo.id}]. ${err}`);
35+
this.logger.debug(`Cannot create summary transform for SLO [${slo.id}]. ${err}`);
3636
if (err.meta?.body?.error?.type === 'security_exception') {
3737
throw new SecurityException(err.meta.body.error.reason);
3838
}
@@ -57,7 +57,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
5757
{ logger: this.logger }
5858
);
5959
} catch (err) {
60-
this.logger.error(`Cannot preview SLO summary transform [${transformId}]. ${err}`);
60+
this.logger.debug(`Cannot preview SLO summary transform [${transformId}]. ${err}`);
6161
throw err;
6262
}
6363
}
@@ -75,7 +75,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
7575
}
7676
);
7777
} catch (err) {
78-
this.logger.error(`Cannot start SLO summary transform [${transformId}]. ${err}`);
78+
this.logger.debug(`Cannot start SLO summary transform [${transformId}]. ${err}`);
7979
throw err;
8080
}
8181
}
@@ -91,7 +91,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
9191
{ logger: this.logger }
9292
);
9393
} catch (err) {
94-
this.logger.error(`Cannot stop SLO summary transform [${transformId}]. ${err}`);
94+
this.logger.debug(`Cannot stop SLO summary transform [${transformId}]. ${err}`);
9595
throw err;
9696
}
9797
}
@@ -107,7 +107,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
107107
{ logger: this.logger }
108108
);
109109
} catch (err) {
110-
this.logger.error(`Cannot delete SLO summary transform [${transformId}]. ${err}`);
110+
this.logger.debug(`Cannot delete SLO summary transform [${transformId}]. ${err}`);
111111
throw err;
112112
}
113113
}
@@ -124,7 +124,7 @@ export class DefaultSummaryTransformManager implements TransformManager {
124124
);
125125
return response?.transforms[0]?._meta?.version;
126126
} catch (err) {
127-
this.logger.error(`Cannot retrieve SLO transform version [${transformId}]. ${err}`);
127+
this.logger.debug(`Cannot retrieve SLO transform version [${transformId}]. ${err}`);
128128
throw err;
129129
}
130130
}

‎x-pack/solutions/observability/plugins/slo/server/services/tasks/orphan_summary_cleanup_task.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export class SloOrphanSummaryCleanupTask {
100100
);
101101

102102
if (sloSummaryIdsToDelete.length > 0) {
103-
this.logger.info(
103+
this.logger.debug(
104104
`[SLO] Deleting ${sloSummaryIdsToDelete.length} SLO Summary documents from the summary index`
105105
);
106106

@@ -227,7 +227,7 @@ export class SloOrphanSummaryCleanupTask {
227227
this.esClient = esClient;
228228

229229
if (!taskManager) {
230-
this.logger.info(
230+
this.logger.debug(
231231
'Missing required service during startup, skipping orphan-slo-summary-cleanup task.'
232232
);
233233
return;

‎x-pack/solutions/observability/plugins/slo/server/services/tasks/temp_summary_cleanup_task.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class TempSummaryCleanupTask {
6363
}
6464

6565
if (!plugins.taskManager) {
66-
this.logger.error('Missing required service during start');
66+
this.logger.debug('Missing required service during start');
6767
return;
6868
}
6969

@@ -108,7 +108,7 @@ export class TempSummaryCleanupTask {
108108
return getDeleteTaskRunResult();
109109
}
110110

111-
this.logger.debug(`runTask() started`);
111+
this.logger.debug(`runTask started`);
112112

113113
const [coreStart] = await core.getStartServices();
114114
const esClient = coreStart.elasticsearch.client.asInternalUser;
@@ -126,7 +126,7 @@ export class TempSummaryCleanupTask {
126126

127127
return;
128128
}
129-
this.logger.error(`Error: ${err}`);
129+
this.logger.debug(`Error: ${err}`);
130130
}
131131
}
132132
}

‎x-pack/solutions/observability/plugins/slo/server/services/transform_generators/common.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export function parseStringFilters(filters: string, logger: Logger) {
3939
try {
4040
return JSON.parse(filters);
4141
} catch (e) {
42-
logger.info(`Failed to parse filters: ${e}`);
42+
logger.debug(`Failed to parse filters: ${e}`);
4343
return {};
4444
}
4545
}

‎x-pack/solutions/observability/plugins/slo/server/services/transform_manager.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export class DefaultTransformManager implements TransformManager {
3434
async install(slo: SLODefinition): Promise<TransformId> {
3535
const generator = this.generators[slo.indicator.type];
3636
if (!generator) {
37-
this.logger.error(`No transform generator found for indicator type [${slo.indicator.type}]`);
37+
this.logger.debug(`No transform generator found for indicator type [${slo.indicator.type}]`);
3838
throw new Error(`Unsupported indicator type [${slo.indicator.type}]`);
3939
}
4040

@@ -47,7 +47,7 @@ export class DefaultTransformManager implements TransformManager {
4747
}
4848
);
4949
} catch (err) {
50-
this.logger.error(
50+
this.logger.debug(
5151
`Cannot create SLO transform for indicator type [${slo.indicator.type}]. ${err}`
5252
);
5353
if (err.meta?.body?.error?.type === 'security_exception') {
@@ -63,7 +63,7 @@ export class DefaultTransformManager implements TransformManager {
6363
async inspect(slo: SLODefinition): Promise<TransformPutTransformRequest> {
6464
const generator = this.generators[slo.indicator.type];
6565
if (!generator) {
66-
this.logger.error(`No transform generator found for indicator type [${slo.indicator.type}]`);
66+
this.logger.debug(`No transform generator found for indicator type [${slo.indicator.type}]`);
6767
throw new Error(`Unsupported indicator type [${slo.indicator.type}]`);
6868
}
6969

@@ -80,7 +80,7 @@ export class DefaultTransformManager implements TransformManager {
8080
{ logger: this.logger }
8181
);
8282
} catch (err) {
83-
this.logger.error(`Cannot preview SLO transform [${transformId}]. ${err}`);
83+
this.logger.debug(`Cannot preview SLO transform [${transformId}]. ${err}`);
8484
throw err;
8585
}
8686
}
@@ -97,7 +97,7 @@ export class DefaultTransformManager implements TransformManager {
9797
);
9898
await this.scheduleNowTransform(transformId);
9999
} catch (err) {
100-
this.logger.error(`Cannot start SLO transform [${transformId}]. ${err}`);
100+
this.logger.debug(`Cannot start SLO transform [${transformId}]. ${err}`);
101101
throw err;
102102
}
103103
}
@@ -113,7 +113,7 @@ export class DefaultTransformManager implements TransformManager {
113113
{ logger: this.logger }
114114
);
115115
} catch (err) {
116-
this.logger.error(`Cannot stop SLO transform [${transformId}]. ${err}`);
116+
this.logger.debug(`Cannot stop SLO transform [${transformId}]. ${err}`);
117117
throw err;
118118
}
119119
}
@@ -129,7 +129,7 @@ export class DefaultTransformManager implements TransformManager {
129129
{ logger: this.logger }
130130
);
131131
} catch (err) {
132-
this.logger.error(`Cannot delete SLO transform [${transformId}]. ${err}`);
132+
this.logger.debug(`Cannot delete SLO transform [${transformId}]. ${err}`);
133133
throw err;
134134
}
135135
}
@@ -146,7 +146,7 @@ export class DefaultTransformManager implements TransformManager {
146146
);
147147
return response?.transforms[0]?._meta?.version;
148148
} catch (err) {
149-
this.logger.error(`Cannot retrieve SLO transform version [${transformId}]. ${err}`);
149+
this.logger.debug(`Cannot retrieve SLO transform version [${transformId}]. ${err}`);
150150
throw err;
151151
}
152152
}
@@ -158,7 +158,7 @@ export class DefaultTransformManager implements TransformManager {
158158
this.logger.debug(`SLO transform [${transformId}] scheduled now successfully`);
159159
})
160160
.catch((e) => {
161-
this.logger.error(`Cannot schedule now SLO transform [${transformId}]. ${e}`);
161+
this.logger.debug(`Cannot schedule now SLO transform [${transformId}]. ${e}`);
162162
});
163163
}
164164
}

‎x-pack/solutions/observability/plugins/slo/server/services/unsafe_federated/remote_summary_doc_to_slo.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ export function fromRemoteSummaryDocumentToSloDefinition(
4848

4949
if (isLeft(res)) {
5050
const errors = formatErrors(res.left);
51-
logger.error(`Invalid remote stored summary SLO with id [${summaryDoc.slo.id}]`);
52-
logger.error(errors.join('|'));
51+
logger.debug(`Invalid remote stored summary SLO with id [${summaryDoc.slo.id}]`);
52+
logger.debug(errors.join('|'));
5353

5454
return undefined;
5555
}
@@ -65,10 +65,10 @@ function getIndicator(summaryDoc: EsSummaryDocument, logger: Logger): Indicator
6565

6666
if (isLeft(res)) {
6767
const errors = formatErrors(res.left);
68-
logger.info(
68+
logger.debug(
6969
`Invalid indicator from remote summary SLO id [${summaryDoc.slo.id}] - Fallback on dummy indicator`
7070
);
71-
logger.info(errors.join('|'));
71+
logger.debug(errors.join('|'));
7272

7373
return getDummyIndicator(summaryDoc);
7474
}

‎x-pack/solutions/observability/plugins/slo/server/services/update_slo.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,15 @@ export class UpdateSLO {
8282
{ logger: this.logger }
8383
);
8484
} catch (err) {
85-
this.logger.error(
85+
this.logger.debug(
8686
`Cannot update the SLO summary pipeline [id: ${updatedSlo.id}, revision: ${updatedSlo.revision}]. ${err}`
8787
);
8888

8989
await asyncForEach(rollbackOperations.reverse(), async (operation) => {
9090
try {
9191
await operation();
9292
} catch (rollbackErr) {
93-
this.logger.error(`Rollback operation failed. ${rollbackErr}`);
93+
this.logger.debug(`Rollback operation failed. ${rollbackErr}`);
9494
}
9595
});
9696

@@ -161,15 +161,15 @@ export class UpdateSLO {
161161
{ logger: this.logger }
162162
);
163163
} catch (err) {
164-
this.logger.error(
164+
this.logger.debug(
165165
`Cannot update the SLO [id: ${updatedSlo.id}, revision: ${updatedSlo.revision}]. Rolling back. ${err}`
166166
);
167167

168168
await asyncForEach(rollbackOperations.reverse(), async (operation) => {
169169
try {
170170
await operation();
171171
} catch (rollbackErr) {
172-
this.logger.error(`Rollback operation failed. ${rollbackErr}`);
172+
this.logger.debug(`Rollback operation failed. ${rollbackErr}`);
173173
}
174174
});
175175

0 commit comments

Comments
 (0)