Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderVTTTokensString does not pass currentTime to recursive call #4

Open
jaco-terbraak opened this issue Aug 15, 2024 · 0 comments
Open

Comments

@jaco-terbraak
Copy link

VTT files can have cue payloads with nested timestamps. However renderVTTTokensString only processes the top-level timestamp according to the passed currentTime. It does not pass the currentTime to the recursive calls, so the nested timestamps don't get the appropriate date-future and date-past attributes.

See: https://github.com/vidstack/captions/blob/main/src/vtt/render-cue.ts#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant