Skip to content

Commit a144df1

Browse files
committed
fix: collection search.
1 parent 620ba99 commit a144df1

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

videodb/collection.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,18 @@ def delete_image(self, image_id: str) -> None:
6969
def search(
7070
self,
7171
query: str,
72-
type: Optional[str] = SearchType.semantic,
72+
search_type: Optional[str] = SearchType.semantic,
7373
result_threshold: Optional[int] = None,
7474
score_threshold: Optional[int] = None,
7575
dynamic_score_percentage: Optional[int] = None,
7676
) -> SearchResult:
77-
search = SearchFactory(self._connection).get_search(type)
77+
search = SearchFactory(self._connection).get_search(search_type)
7878
return search.search_inside_collection(
79-
self.id,
80-
query,
81-
result_threshold,
82-
score_threshold,
83-
dynamic_score_percentage,
79+
collection_id=self.id,
80+
query=query,
81+
result_threshold=result_threshold,
82+
score_threshold=score_threshold,
83+
dynamic_score_percentage=dynamic_score_percentage,
8484
)
8585

8686
def upload(

videodb/search.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def search_inside_video(
174174
)
175175
return SearchResult(self._connection, **search_data)
176176

177-
def search_inside_collection(**kwargs):
177+
def search_inside_collection(self, **kwargs):
178178
raise NotImplementedError("Keyword search will be implemented in the future")
179179

180180

@@ -202,10 +202,9 @@ def search_inside_video(
202202
"result_threshold": result_threshold,
203203
},
204204
)
205-
print(search_data)
206205
return SearchResult(self._connection, **search_data)
207206

208-
def search_inside_collection(**kwargs):
207+
def search_inside_collection(self, **kwargs):
209208
raise NotImplementedError("Scene search will be implemented in the future")
210209

211210

0 commit comments

Comments
 (0)