Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untracked files are appearing as new/added files #31

Open
victor-torres opened this issue Oct 8, 2016 · 3 comments
Open

Untracked files are appearing as new/added files #31

victor-torres opened this issue Oct 8, 2016 · 3 comments

Comments

@victor-torres
Copy link
Owner

screen shot 2016-10-08 at 17 41 20

screen shot 2016-10-08 at 17 42 16

I’m not sure these files should be shown in the green color.

@victor-torres
Copy link
Owner Author

victor-torres commented Oct 8, 2016

@TomKemperNL I’ve noticed that untracked files also appear in green using git repositories. What do you think: should we leave it green?

JetBrains shows untracked files in red. Showing these files in green is a mistake IMHO because we tend to think these files are tracked/added and staged for the next commit.

screen shot 2016-10-08 at 18 08 57

@victor-torres
Copy link
Owner Author

The pull request #32 now returns whether a path or status is staged or not. This won’t change anything since Atom shows not staged files in green as noticed with git repositories. But we’ll be ready when they start to show it in red or some other text formatting.

@victor-torres
Copy link
Owner Author

victor-torres commented Oct 8, 2016

There’s already an issue for that in Atom’s tree-view plugin repository

I propose the following change:

files which have a red M in the git cli should be orange in tree-view
files which have a green M in the git cli should be green in tree-view

atom/tree-view#430

In Mercurial it’s easier to identify untracked files because every removed/modified/added file is automatically staged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant