-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HgUtils async #15
Labels
Comments
@mrstebo I further investigated based on your suggestions and I can confirm the blame is in the spawnSync guy. |
I noticed it when I was doing a |
Yup. Sounds good. Exactly what I would do. |
@mrstebo are you up to this one? May I assign it to you? |
I guess I could have a crack at it 😅 |
This was referenced Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
spawnSync blocks NodeJS and we can't have another process/thread running it such as a web worker... We have to refactor HgUtils class to use spawn or exec, the asynchronous version of this command. Basically we need to encapsulate some methods into promises and consume them with .then() in HgRepositoryAsync class.
The text was updated successfully, but these errors were encountered: