Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI option required but not used when socket is provided #25

Open
mgwidmann opened this issue Oct 9, 2017 · 2 comments
Open

URI option required but not used when socket is provided #25

mgwidmann opened this issue Oct 9, 2017 · 2 comments

Comments

@mgwidmann
Copy link

In the following code, the uri option is required to be passed in, even though its not used since the socket parameter is provided. I've used this to supply my own socket connection parameters.

createNetworkInterface({
    uri: '/this-does-not-matter',
    Socket: () => { return socket; }
  });
@vic
Copy link
Owner

vic commented Oct 24, 2017

Oh right, thanks for reporting this, are you interested in sending an small PR ?

@mgwidmann
Copy link
Author

Yeah I can take a look... All you'd want is just to not have to pass it in then right? Should be just something like { Socket: () => { return socket; } } passed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants