-
Notifications
You must be signed in to change notification settings - Fork 114
/
Copy pathcloud_package_manager.go
614 lines (506 loc) · 16.3 KB
/
cloud_package_manager.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
package packages
import (
"archive/tar"
"compress/gzip"
"context"
"encoding/base64"
"fmt"
"hash"
"hash/crc32"
"io"
"net/http"
"net/url"
"os"
"path"
"path/filepath"
"regexp"
"strings"
"sync"
"time"
"github.com/edaniels/golog"
"github.com/pkg/errors"
"go.uber.org/multierr"
pb "go.viam.com/api/app/packages/v1"
"go.viam.com/utils"
"go.viam.com/rdk/config"
"go.viam.com/rdk/resource"
)
const (
allowedContentType = "application/x-gzip"
)
var (
_ Manager = (*cloudManager)(nil)
_ ManagerSyncer = (*cloudManager)(nil)
)
type managedPackage struct {
thePackage config.PackageConfig
modtime time.Time
}
// group 1: entire placeholder 2: type (if it exists + including the period) 3: the package name.
// TODO:.
var placeholderRegexp = regexp.MustCompile(`^\$\{(packages(\.(ml_models|modules))?\.([\w/-]+))\}`)
type cloudManager struct {
resource.Named
// we assume the config is immutable for the lifetime of the process
resource.TriviallyReconfigurable
client pb.PackageServiceClient
httpClient http.Client
packagesDataDir string
packagesDir string
managedPackages map[PackageName]*managedPackage
mu sync.RWMutex
logger golog.Logger
}
// SubtypeName is a constant that identifies the internal package manager resource subtype string.
const SubtypeName = "packagemanager"
// API is the fully qualified API for the internal package manager service.
var API = resource.APINamespaceRDKInternal.WithServiceType(SubtypeName)
// InternalServiceName is used to refer to/depend on this service internally.
var InternalServiceName = resource.NewName(API, "builtin")
// NewCloudManager creates a new manager with the given package service client and directory to sync to.
func NewCloudManager(client pb.PackageServiceClient, packagesDir string, logger golog.Logger) (ManagerSyncer, error) {
packagesDataDir := filepath.Join(packagesDir, ".data")
if err := os.MkdirAll(packagesDir, 0o700); err != nil {
return nil, err
}
if err := os.MkdirAll(packagesDataDir, 0o700); err != nil {
return nil, err
}
return &cloudManager{
Named: InternalServiceName.AsNamed(),
client: client,
httpClient: http.Client{Timeout: time.Minute * 30},
packagesDir: packagesDir,
packagesDataDir: packagesDataDir,
managedPackages: make(map[PackageName]*managedPackage),
logger: logger.Named("package_manager"),
}, nil
}
// PackagePath returns the package if it exists and already download. If it does not exist it returns a ErrPackageMissing error.
func (m *cloudManager) PackagePath(name PackageName) (string, error) {
m.mu.RLock()
defer m.mu.RUnlock()
p, ok := m.managedPackages[name]
if !ok {
return "", ErrPackageMissing
}
return m.localNamedPath(p.thePackage), nil
}
func (m *cloudManager) getPackageFromType(pt string) (config.PackageType, error) {
switch pt {
case "ml_models":
return config.PackageTypeMlModel, nil
case "modules":
return config.PackageTypeModule, nil
case "":
// valid type until type migration
return "", nil
default:
return "", fmt.Errorf("invalid package type %s in placeholder", pt)
}
}
func (m *cloudManager) PlaceholderPath(path string) (*PlaceholderRef, error) {
matches := placeholderRegexp.FindStringSubmatch(path)
if len(matches) == 0 {
return nil, fmt.Errorf("invalid package placeholder path: %s", path)
}
placeholderRef := &PlaceholderRef{
matchedPlaceholder: matches[0],
nestedPath: matches[1],
packageName: matches[4],
}
pt, err := m.getPackageFromType(matches[3])
if err != nil {
return nil, err
}
placeholderRef.packageType = pt
return placeholderRef, nil
}
// Close manager.
func (m *cloudManager) Close(ctx context.Context) error {
m.mu.Lock()
defer m.mu.Unlock()
m.httpClient.CloseIdleConnections()
return nil
}
// SyncAll syncs all given packages and removes any not in the list from the local file system.
func (m *cloudManager) Sync(ctx context.Context, packages []config.PackageConfig) error {
var outErr error
// Only allow one rdk process to operate on the manager at once. This is generally safe to keep locked for an extended period of time
// since the config reconfiguration process is handled by a single thread.
m.mu.Lock()
defer m.mu.Unlock()
newManagedPackages := make(map[PackageName]*managedPackage, len(packages))
for idx, p := range packages {
select {
case <-ctx.Done():
return multierr.Append(outErr, ctx.Err())
default:
}
if err := p.Validate(""); err != nil {
m.logger.Debugf("package config validation error; skipping", "package", p.Name, "error", err)
continue
}
start := time.Now()
m.logger.Debugf("Starting package sync [%d/%d] %s:%s", idx+1, len(packages), p.Package, p.Version)
// Package exists in known cache.
existing, ok := m.managedPackages[PackageName(p.Name)]
if ok {
if existing.thePackage.Package == p.Package && existing.thePackage.Version == p.Version {
m.logger.Debug(" Package already managed, skipping")
newManagedPackages[PackageName(p.Name)] = existing
delete(m.managedPackages, PackageName(p.Name))
continue
}
// anything left over in the m.managedPackages will be cleaned up later.
}
// Lookup the packages http url
includeURL := true
resp, err := m.client.GetPackage(ctx, &pb.GetPackageRequest{Id: p.Package, Version: p.Version, IncludeUrl: &includeURL})
if err != nil {
m.logger.Errorf("Failed fetching package details for package %s:%s, %s", p.Package, p.Version, err)
outErr = multierr.Append(outErr, errors.Wrapf(err, "failed loading package url for %s:%s", p.Package, p.Version))
continue
}
m.logger.Debugf(" Downloading from %s", sanitizeURLForLogs(resp.Package.Url))
// load package from a http endpoint
err = m.loadFile(ctx, resp.Package.Url, p)
if err != nil {
m.logger.Errorf("Failed downloading package %s:%s from %s, %s", p.Package, p.Version, sanitizeURLForLogs(resp.Package.Url), err)
outErr = multierr.Append(outErr, errors.Wrapf(err, "failed downloading package %s:%s from %s",
p.Package, p.Version, sanitizeURLForLogs(resp.Package.Url)))
continue
}
err = linkFile(m.localDataPath(p), m.localNamedPath(p))
if err != nil {
m.logger.Errorf("Failed linking package %s:%s, %s", p.Package, p.Version, err)
outErr = multierr.Append(outErr, err)
continue
}
// add to managed packages
newManagedPackages[PackageName(p.Name)] = &managedPackage{thePackage: p, modtime: time.Now()}
m.logger.Debugf(" Sync complete after %dms", time.Since(start).Milliseconds())
}
// swap for new managed packags.
m.managedPackages = newManagedPackages
return outErr
}
// Cleanup removes all unknown packages from the working directory.
func (m *cloudManager) Cleanup(ctx context.Context) error {
m.logger.Debug("Starting package cleanup")
// Only allow one rdk process to operate on the manager at once. This is generally safe to keep locked for an extended period of time
// since the config reconfiguration process is handled by a single thread.
m.mu.Lock()
defer m.mu.Unlock()
var allErrors error
// packageDir will contain either symlinks to the packages or the .data directory.
files, err := os.ReadDir(m.packagesDir)
if err != nil {
return err
}
// keep track of known packages by their hashed name from the package id and version.
knownPackages := make(map[string]bool)
// first remove all symlinks to the packages themself.
for _, f := range files {
if f.Type()&os.ModeSymlink == os.ModeSymlink {
// if managed skip removing package
if p, ok := m.managedPackages[PackageName(f.Name())]; ok {
knownPackages[p.thePackage.SanitizeName()] = true
continue
}
m.logger.Infof("Cleaning up unused package link %s", f.Name())
// Remove logical symlink to package
if err := os.Remove(path.Join(m.packagesDir, f.Name())); err != nil {
allErrors = multierr.Append(allErrors, err)
}
}
}
// remove any packages in the .data dir that aren't known to the manager.
// packageDir will contain either symlinks to the packages or the .data directory.
files, err = os.ReadDir(m.packagesDataDir)
if err != nil {
return err
}
// remove any remaining files in the .data dir that should not be there.
for _, f := range files {
// if managed skip removing package
if _, ok := knownPackages[f.Name()]; ok {
continue
}
m.logger.Debugf("Cleaning up unused package %s", f.Name())
// Remove logical symlink to package
if err := os.RemoveAll(path.Join(m.packagesDataDir, f.Name())); err != nil {
allErrors = multierr.Append(allErrors, err)
}
}
return allErrors
}
func sanitizeURLForLogs(u string) string {
parsed, err := url.Parse(u)
if err != nil {
return ""
}
parsed.RawQuery = ""
return parsed.String()
}
func (m *cloudManager) loadFile(ctx context.Context, url string, p config.PackageConfig) error {
// TODO(): validate integrity of directory.
if dirExists(m.localDataPath(p)) {
m.logger.Debug(" Package already downloaded, skipping.")
return nil
}
// Force redownload of package archive.
if err := m.cleanup(p); err != nil {
m.logger.Debug(err)
}
if err := os.Remove(m.localNamedPath(p)); err != nil {
m.logger.Debug(err)
}
// Download from GCS
_, contentType, err := m.downloadFileFromGCSURL(ctx, url, p)
if err != nil {
return err
}
if contentType != allowedContentType {
utils.UncheckedError(m.cleanup(p))
return fmt.Errorf("unknown content-type for package %s", contentType)
}
// unpack to temp directory to ensure we do an atomic rename once finished.
tmpDataPath, err := os.MkdirTemp(m.packagesDataDir, "*.tmp")
if err != nil {
return errors.Wrap(err, "failed to create temp data dir path")
}
defer func() {
// cleanup archive file.
if err := os.Remove(m.localDownloadPath(p)); err != nil {
m.logger.Debug(err)
}
if err := os.Remove(tmpDataPath); err != nil {
m.logger.Debug(err)
}
}()
// unzip archive.
err = m.unpackFile(ctx, m.localDownloadPath(p), tmpDataPath)
if err != nil {
utils.UncheckedError(m.cleanup(p))
return err
}
err = os.Rename(tmpDataPath, m.localDataPath(p))
if err != nil {
utils.UncheckedError(m.cleanup(p))
return err
}
return nil
}
func (m *cloudManager) cleanup(p config.PackageConfig) error {
return multierr.Combine(
os.RemoveAll(m.localDataPath(p)),
os.Remove(m.localDownloadPath(p)),
)
}
func (m *cloudManager) downloadFileFromGCSURL(ctx context.Context, url string, p config.PackageConfig) (string, string, error) {
downloadPath := m.localDownloadPath(p)
getReq, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
if err != nil {
return "", "", err
}
//nolint:bodyclose /// closed in UncheckedErrorFunc
resp, err := m.httpClient.Do(getReq)
if err != nil {
return "", "", err
}
defer utils.UncheckedErrorFunc(resp.Body.Close)
if resp.StatusCode != http.StatusOK {
return "", "", fmt.Errorf("invalid status code %d", resp.StatusCode)
}
contentType := resp.Header.Get("Content-Type")
checksum := getGoogleHash(resp.Header, "crc32c")
//nolint:gosec // safe
out, err := os.Create(downloadPath)
if err != nil {
return checksum, contentType, err
}
defer utils.UncheckedErrorFunc(out.Close)
hash := crc32Hash()
w := io.MultiWriter(out, hash)
_, err = io.CopyN(w, resp.Body, maxPackageSize)
if err != nil && !errors.Is(err, io.EOF) {
utils.UncheckedError(os.Remove(downloadPath))
return checksum, contentType, err
}
outHash := base64.StdEncoding.EncodeToString(hash.Sum(nil))
if outHash != checksum {
utils.UncheckedError(os.Remove(downloadPath))
return checksum, contentType, errors.Errorf("download did not match expected hash %s != %s", checksum, outHash)
}
return checksum, contentType, nil
}
func (m *cloudManager) unpackFile(ctx context.Context, fromFile, toDir string) error {
if err := os.MkdirAll(toDir, 0o700); err != nil {
return err
}
//nolint:gosec // safe
f, err := os.Open(fromFile)
if err != nil {
return err
}
defer utils.UncheckedErrorFunc(f.Close)
archive, err := gzip.NewReader(f)
if err != nil {
return err
}
defer utils.UncheckedErrorFunc(archive.Close)
type link struct {
Name string
Path string
}
links := []link{}
symlinks := []link{}
tarReader := tar.NewReader(archive)
for {
select {
case <-ctx.Done():
return errors.New("interrupted")
default:
}
header, err := tarReader.Next()
if errors.Is(err, io.EOF) {
break
}
if err != nil {
return errors.Wrap(err, "read tar")
}
path := header.Name
if path == "" || path == "./" {
continue
}
if path, err = safeJoin(toDir, path); err != nil {
return err
}
info := header.FileInfo()
switch header.Typeflag {
case tar.TypeDir:
if err := os.Mkdir(path, info.Mode()); err != nil {
return errors.Wrapf(err, "failed to create directory %s", path)
}
case tar.TypeReg:
// This is required because it is possible create tarballs without a directory entry
// but whose files names start with a new directory prefix
// Ex: tar -czf package.tar.gz ./bin/module.exe
parent := filepath.Dir(path)
if err := os.MkdirAll(parent, info.Mode()); err != nil {
return errors.Wrapf(err, "failed to create directory %q", parent)
}
//nolint:gosec // path sanitized with safeJoin
outFile, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_TRUNC, info.Mode().Perm())
if err != nil {
return errors.Wrapf(err, "failed to create file %s", path)
}
if _, err := io.CopyN(outFile, tarReader, maxPackageSize); err != nil && !errors.Is(err, io.EOF) {
return errors.Wrapf(err, "failed to copy file %s", path)
}
utils.UncheckedError(outFile.Close())
case tar.TypeLink:
name := header.Linkname
if name, err = safeJoin(toDir, name); err != nil {
return err
}
links = append(links, link{Path: path, Name: name})
case tar.TypeSymlink:
linkTarget, err := safeLink(toDir, header.Linkname)
if err != nil {
return err
}
symlinks = append(symlinks, link{Path: path, Name: linkTarget})
}
}
// Now we make another pass creating the links
for i := range links {
select {
case <-ctx.Done():
return errors.New("interrupted")
default:
}
if err := linkFile(links[i].Name, links[i].Path); err != nil {
return errors.Wrapf(err, "failed to create link %s", links[i].Path)
}
}
for i := range symlinks {
select {
case <-ctx.Done():
return errors.New("interrupted")
default:
}
if err := linkFile(symlinks[i].Name, symlinks[i].Path); err != nil {
return errors.Wrapf(err, "failed to create link %s", links[i].Path)
}
}
return nil
}
func (m *cloudManager) localDownloadPath(p config.PackageConfig) string {
return filepath.Join(m.packagesDataDir, fmt.Sprintf("%s.download", p.Name))
}
func (m *cloudManager) localDataPath(p config.PackageConfig) string {
return filepath.Join(m.packagesDataDir, p.SanitizeName())
}
func (m *cloudManager) localNamedPath(p config.PackageConfig) string {
return filepath.Join(m.packagesDir, p.Name)
}
func getGoogleHash(headers http.Header, hashType string) string {
hashes := headers.Values("x-goog-hash")
hashesMap := make(map[string]string, len(hashes))
for _, v := range hashes {
split := strings.SplitN(v, "=", 2)
if len(split) != 2 {
continue
}
hashesMap[split[0]] = split[1]
}
return hashesMap[hashType]
}
func crc32Hash() hash.Hash32 {
return crc32.New(crc32.MakeTable(crc32.Castagnoli))
}
// safeJoin performs a filepath.Join of 'parent' and 'subdir' but returns an error
// if the resulting path points outside of 'parent'.
func safeJoin(parent, subdir string) (string, error) {
res := filepath.Join(parent, subdir)
if !strings.HasSuffix(parent, string(os.PathSeparator)) {
parent += string(os.PathSeparator)
}
if !strings.HasPrefix(res, parent) {
return res, errors.Errorf("unsafe path join: '%s' with '%s'", parent, subdir)
}
return res, nil
}
func safeLink(parent, link string) (string, error) {
if filepath.IsAbs(link) {
return link, errors.Errorf("unsafe path link: '%s' with '%s', cannot be absolute path", parent, link)
}
_, err := safeJoin(parent, link)
if err != nil {
return link, err
}
return link, nil
}
func linkFile(from, to string) error {
link, err := os.Readlink(to)
if err != nil && !errors.Is(err, os.ErrNotExist) {
return err
}
if link == from {
return nil
}
// remove any existing link or SymLink will fail.
if link != "" {
utils.UncheckedError(os.Remove(from))
}
return os.Symlink(from, to)
}
func dirExists(dir string) bool {
info, err := os.Stat(dir)
if err != nil {
return false
}
return info.IsDir()
}